[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 6/8] pci/arm: don't do iommu call for phantom functions
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 12 May 2023 09:28:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nhtq7GtNdwkIwhtvega7bfE7ScUQN4DDpCOQvM8/moA=; b=cP/JJrSCuR2OGoPjFv3PkqE8iJ+R4lE3YoHaNbAiyXKjXttaJvxEttyhqCqkFEcDvGvNEB8Upp00tyOjAugnIQfqvgs35ybsd4V2FJu2KuLYKg4dCtguHR5MT8cE/oNh/49/1AjGoFe1K3kf124rgBahx7qlK36NqlYsFOpSpcKu/CsrH7tcSjH3pxtSQj/EDYW7QWXrW+33EgxsAP/JURrqBeXRs2fZpT2e5de2t5oQjPUqOG4exkqZVUr3sL/wlZAMOl1v08BfB+YuQenTe/0dSCmVMepJPd4aSoopXzsOXX2JRQFM/EB9xg+e2YvRWVYxWho+a04vUMLHKofHlQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPJiV/InSLocZuBH8aFP4xc/k/XHfhZIDFMIYJ+jPKujGgOhK/sZtkqu8PzKv93VeaLu04uUzg80i1rN72WzJXGbJWm9OLNmOnKh4Ap9ixCC4rwHoj6b7chASxIgkVNYWenFtl17ZD1456qo4sP/jhW57zGhHN4AwNqQ2RVaev3OwnUHBlYhdJ5nRpTxfbBJcOduS8sv83/83QdpeTuOCALdb2eXsGVK2BejGDDhsHgNDi1sQttLvXSIM8HQNBxq4P66acYDQye/j/gtOPJ72C31Ab/TL2QjbfnVWCcXZo2b52kmHVfAxVkZkaUVYvAd7kdixzfcDdjFjI1ioBIyeQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 12 May 2023 07:28:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.05.2023 21:16, Stewart Hildebrand wrote:
> It's not necessary to add/remove/assign/deassign pci phantom functions
> for the ARM SMMU drivers. All associated AXI stream IDs are added during
> the iommu call for the base PCI device/function.
>
> However, the ARM SMMU drivers can cope with the extra/unnecessary calls just
> fine, so this patch is RFC as it's not strictly required.
Tying the skipping to IS_ENABLED(CONFIG_HAS_DEVICE_TREE) goes against
one of Julien's earlier comments, towards DT and ACPI wanting to
co-exist at some point. So I think keeping the supposedly unnecessary
calls is going to be unavoidable, unless you have a runtime property
that you could check instead.
Jan
|
