[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Fix install.sh for systemd
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 12 May 2023 12:22:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o9IqwSYdBzXQ+2BuXRI4uXzPjierc5LrVwnlz/pewMA=; b=k8ZatOay22zmMfm7NnIhFthxzLqA7WWAGqR6bbVmDsJ5/6LikLZf9ThuUZtpaD+beIRjE5cIz+ug7zlazm1YhK2+AQO9bdsvMshPXExQ7LFbBIKf4rNeaCV2PfPedUa8VxZOWfoBO+9W1MlQApiZp6U1YuMr6TFqGGula+42V7EgZEsM53hzvwQpgUgPK5Q9zqPdqqWmRUL0eWj6oJxU+EhCm8EcBy8j+c1g7wfS5+Ugz2fphoNmqA+RDjFIDgTdVGiEBdxHfcWE9hsyjIeTnzolcLl+GQ0BPS2n7JzFEP9kA7tFI3NUD6IOFf/kvKszSNRhNNilUj0c+LtNd5NbGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lff92meAxxqWDgZl54ckOwthIlF769MnRvgFGTfeomulWQiDY7kBwN4fHU3EFyTPUY7rA1I/Q3+2m4pRMbnD2Q4YGIwLKv4k0EQ1ZBRQxi1bvg9gJANd95iU9O//66bf5bO0f3Bm0P31GUIDgInHq/PeKMiAUs4CdTq7UQcw3anQHrYWk3M8BLl282U0qpnOn+C5R8Ha5j4TLno6Wzw5shzA1heTRX0J/wuxkikNuL7hb1g3R1p3iVHPVsdwbQPNNW/aZjZUeWVvaq9nj6+6qfzMnRCC5iD7hyNNggAFJii9Z9tN1DMmOmYomgY9o1Yyn9RzarDAQVPlLNXxK1lZaA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jason Andryuk <jandryuk@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 12 May 2023 11:22:29 +0000
- Ironport-data: A9a23:7LFhO6IqTL64fSuWFE+R7ZQlxSXFcZb7ZxGr2PjKsXjdYENSgWcDm 2FNUG+PPK6KMGagc9wlaI++8U4E6JfSytBlTgNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wVkPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5uA3Nnz +EZKgpSbz7Sm/Of6bWqc+1z05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLnWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHurCNhKRO3hnhJsqF2Q9mIOJERPaQeAjMC8t1W9UIx+C VNBr0LCqoB3riRHVOLVWBmxrlaNswYSX9cWH+BSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHsrSTRWiM67S8oja7OCxTJmgHDQcbSSMV7t+lp5s85i8jVf5mGa+xy9HwRzf5x mnSqDBk3u1Cy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:szD9o6lEKTVzCQaXCqvzCrIp4XLpDfLa3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRcdcLW7UpVoLkmyyXcY2+cs1PKZLWvbUQiTXeZfBOnZsl7d8kTFn4Yw6U 4jSdkaNDSZNzNHZK3BkW2F+rgboeVu8MqT9JjjJ3UGd3AVV0m3hT0JezpyESdNNXl77YJSLu vk2iLezQDQBEj+aK6AdwE4dtmGnfLnvrT8byULAhY2gTP+8Q9BuNbBYmOlNg51aUI0/Ysf
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/05/2023 12:18 pm, Olaf Hering wrote:
> Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>
>> Why is this 700, and the others just using regular perms?
>> Also, doesn't it want quoting like the other examples too?
> It is not clear why there is a single mkdir -m 0700 in the tree.
> Most likely it will not give any extra security.
I agree. It's weird and doesn't have a good reason for being different.
> The scripts source hotplug.sh, which defines a variable XEN_RUN_DIR.
> I think it is better to use the shell variable instead of hardcoded paths.
Sounds good. Does this allow for making any of these files no longer
preprocessed by ./configure ? (i.e. cease being .in files)
> Regarding quoting: there are many paths used without quoting.
> For the beauty an additional (huge) change could be done to quote
> everything. Not sure if it is worth the effort...
Perhaps, but variables should always be quoted. At least make sure that
new additions (and edits) leave things quoted.
Thanks,
~Andrew
|
