[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Olaf Hering <olaf@xxxxxxxxx>
- Date: Fri, 12 May 2023 13:51:55 +0200
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683892329; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=4pO3OeqHNQDQyAaWXS+vdNOuErKYYtDSH/h/zsSid+E=; b=gqOFTSO+w3MnjYmwnNWfwKOlLE3UyOK5JFvO6vPsLM7vQ/sl9va5mX4H9fsl4xrjpp S8FdvkCCFnbNqRt661ua17QTnF/eUgQ1BXP1mUaeJcc8b+/4GYuMGrxhzKjETjyjcJwL /e5D2wGUZhr/UJMu0AVBcBPIWujrjXoRl2lkM2RyzZGWwqZapatfzUE5E78cP4lSbVOi n/q0W634+kPFWfx62vimGJmBEkbC7e60yFVfGGq0ZixwMKtPZqCPPBLtJYug76zFuplx w944s/Cuhzb4VQS9S8hXVQ+HYNjk+CfRc3fFsZEsTMYZfkhebFUJFIaA13FZglu8gr02 NtiA==
- Arc-seal: i=1; a=rsa-sha256; t=1683892329; cv=none; d=strato.com; s=strato-dkim-0002; b=M4ovsXlVQlninO635eY0mKR8DuDh0BZQlf38BK/4NTBcRQj4b0Knz2L3molYqY77lU NLCLi+kfneJY6CnaEFsUDOC0IBlDGci8HuzwvgxoFfmvMXL6+dX5O8yMIX4+Ykrnlr0O Ns7v6eoWEDv3h7+xqaHn6p7qm5ZEm43rD7S1Uk4vETJcwK2Kwz7DQ+4LNOrKYkew7lEM E65gm2mL25BC7h21VBM9qeJBOHd67y4AuUtH2R8CQgfUVSmMRSniqG1vTx+d32isF7lG aLjo51pF6tmZMhA9h3NCJjifcTzObQMVvhE8vWwCP6pnIx9XpaZazaxI79xu24ITYxfb d6RQ==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 12 May 2023 11:52:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Tue, 9 May 2023 17:47:33 +0100 Anthony PERARD <anthony.perard@xxxxxxxxxx>:
> That change isn't enough. And I'm not convinced that it needs to be
> removed.
You are right, the provided functions must be removed as well.
My build scripts do not run autoreconf, perhaps it is about time to
change that.
> First, AX_CHECK_PTYFUNCS is still called in "tools/configure.ac".
This needs to be removed, yes.
> Then, AX_CHECK_PTYFUNCS define INCLUDE_LIBUTIL_H and PTYFUNCS_LIBS.
This is used inconsistently. Some places include <libutil.h> unconditionally.
-lutil is already used unconditionally via UTIL_LIBS
> Also, that that macro isn't just about the header, but also about the
> needed library.
This is already covered.
Olaf
Attachment:
pgpcfe1X_w1Ss.pgp
Description: Digitale Signatur von OpenPGP
|
