[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] xen/arm: smmuv3: Advertise coherent table walk if supported


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Mon, 15 May 2023 08:32:41 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9g3xWrl8pnopm5cFv/kjePR0wYB/NRo+6fpX922euJw=; b=ogo3+zb/rMOlPdEIn93Y7+GDtNGPp0Uaa0CSHHs4b6HN+1lpsqR15OcsRHh7e3uGeyYFcDX8sTRHp9hk0ev59XjG0I4Bx9cB3TR1AWOOo0EhRP+mkmA+r2mx7zdb3lRedYdHmIPczSoWiBRI7Gwyf/Lto6qfjnP5ciuq9I3KGzyomoVWjShYnDhe2RSGAVwdogAFkcKD4TIkiUkYlL18ryHFgSCb8dBIHQpb/LZil4+KvedJYsHm+8zJDKxV6dzp4LN3f5K41z+7MxZss9LeuL6/NL9Ilv8IrzunhLE9CqhTxMkcScAAeBLhTJOh/NcfrLFeXD+2YuS4W+DTvn4oGw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZxBnVmrVBhk07qVv2+f62mH83nEcGczce+raWAdd82ylIfoTt/zbt+Zkv1ZzD76JMz+iL+d2dxFTVFfbBO8BWQ26+zuPXc0M3DmAR+KnZhF833M6wRRoQjmC9oJfowYTt1AJSRqOGoy85o9ibTeiWI7LB0uWvWlt1eFfohaSyWMWESvRCJC6Diw7CUC/aEVfSzZ6d6nKJ1VZkz2drgNhd35qe2La6uRhUaptFTZLRCt0xipVl664fwl/iyPeFy/kM3vCGi9DbSjaHNlsNK9XI3XvYkRSLxaEgKvUCGomzlSg3FhFsUTZSXr7DpUKXWoW2UJCyOKXjuBfW+KqDM0Qsg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 15 May 2023 08:33:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZhN8Uzg8I+HOn4k6B42UqpaPyEa9bBdQA
  • Thread-topic: [PATCH 2/2] xen/arm: smmuv3: Advertise coherent table walk if supported

Hi Michal,


On 12 May 2023, at 3:35 pm, Michal Orzel <michal.orzel@xxxxxxx> wrote:

At the moment, even in case of a SMMU being I/O coherent, we clean the
updated PT as a result of not advertising the coherency feature. SMMUv3
coherency feature means that page table walks, accesses to memory
structures and queues are I/O coherent (refer ARM IHI 0070 E.A, 3.15).

Follow the same steps that were done for SMMU v1,v2 driver by the commit:
080dcb781e1bc3bb22f55a9dfdecb830ccbabe88

The same restrictions apply, meaning that in order to advertise coherent
table walk platform feature, all the SMMU devices need to report coherency
feature. This is because the page tables (we are sharing them with CPU)
are populated before any device assignment and in case of a device being
behind non-coherent SMMU, we would have to scan the tables and clean
the cache.

It is to be noted that the SBSA/BSA (refer ARM DEN0094C 1.0C, section D)
requires that all SMMUv3 devices support I/O coherency.

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>

Regards,
Rahul 


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.