[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] m4/ptyfuncs.m4 tools/configure: add linux headers for pty functions



On 16/05/2023 12.34, Andrew Cooper wrote:
On 16/05/2023 10:13 am, Florian Schmaus wrote:
To avoid implicit function declarations, which will cause an error on
modern compilers. See https://wiki.gentoo.org/wiki/Modern_C_porting

Downstream Gentoo bug: https://bugs.gentoo.org/904449

Signed-off-by: Florian Schmaus <flo@xxxxxxxxxxxx>

Thanks for the patch, but there's already a different fix in flight.

Thanks for the fast response pointing out the other patch.

Does
https://lore.kernel.org/xen-devel/20230512122614.3724-1-olaf@xxxxxxxxx/
work for you?  If so, we'd definitely prefer to take the deletion of
obsolete functionality.

After a quick glance at the patch I believe that it would also achieve the same goal, while it is better than my approach.

- Florian



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.