[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator
- To: Chuck Zmudzinski <brchuckz@xxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Michael Tokarev <mjt@xxxxxxxxxx>
- Date: Wed, 17 May 2023 09:39:47 +0300
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-stable@xxxxxxxxxx
- Delivery-date: Wed, 17 May 2023 06:39:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
08.02.2023 05:03, Chuck Zmudzinski wrote:
Commit 998250e97661 ("xen, gfx passthrough: register host bridge specific
to passthrough") uses the igd-passthrough-i440FX pci host device with
the xenfv machine type and igd-passthru=on, but using it for the pc
machine type, xen accelerator, and igd-passtru=on was omitted from that
commit.
The igd-passthru-i440FX pci host device is also needed for guests
configured with the pc machine type, the xen accelerator, and
igd-passthru=on. Specifically, tests show that not using the igd-specific
pci host device with the Intel igd passed through to the guest results
in slower startup performance and reduced resolution of the display
during startup. This patch fixes this issue.
To simplify the logic that is needed to support both the --enable-xen
and the --disable-xen configure options, introduce the boolean symbol
pc_xen_igd_gfx_pt_enabled() whose value is set appropriately in the
sysemu/xen.h header file as the test to determine whether or not
to use the igd-passthrough-i440FX pci host device instead of the
normal i440FX pci host device.
Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge specific to
passthrough")
Signed-off-by: Chuck Zmudzinski <brchuckz@xxxxxxx>
Has this change been forgotten? Is it not needed anymore?
Thanks,
/mjt
|
