[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] x86/cpufeature: Rework {boot_,}cpu_has()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 17 May 2023 16:01:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jhY/zICz1UVzbcRZk5W3O1k5IkbOKELYWA2ukALRJ3Q=; b=WSlfy5ADOdgRgsrJ3+533xzW2VxW5LMvWTmq1t0MVWYkd440+iRkgTzAaQeAP3+F7+3XyXqq/NRgaCd08s9kulDhtrDQb52o2e32YJC/Kg+WQPsDyfLYJDojJ3pzKdBeX0FT40cOTQ2QKRaNOH0AjJOnTShEmrJQWggrn/CXUOaEZHNm4Xg3/uVJHebfz+Rqcgm5tVCKH0ZUjzsfcXSD8A9wn5PfkJUR9y7IHygMymyY7GrL/lp0LmkVsPvYSOAvds5AUhbIqSlYgKtgIsqYjDEHZOYxMgaBu3mNWUFnM5SBzv9DKAxRZ3YWiiRpfb9DfjH2T6J8Vm533XEjlz/aQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1FduhauMfMoeukXmqFMEmhvto33x3Zj6lyJgLKqIENnWjpjc0Fv1h+n1xcsbUWKQQ50BV2cSAOJ4qtoOxjihi4xTSVNodfs7bOQs53Z1XlXQYIDAwBPWZkuN3wxfTmy9KmgxzgjLT8E+IeeHjvyb31JhFKGb3lJS3shs9WoUiWU2aTvyoDERQV5QZjNfHamxrC0ym1dZVzZbsjcSXMThyzSpMZFkQl3m+PA5kddz++P8pLf+wu0Ht2c8eKjthwZFNgeD0XdiQtJQTUOvRzTVkxlNOXWUpNkjql3J1jE22ntBYBJDHC/QVsQUqFPvepLq0z/hA7fS9xh2Fy4ysHuAA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 17 May 2023 14:01:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.05.2023 16:53, Andrew Cooper wrote:
> --- a/xen/arch/x86/include/asm/cpufeature.h
> +++ b/xen/arch/x86/include/asm/cpufeature.h
> @@ -7,6 +7,7 @@
> #define __ASM_I386_CPUFEATURE_H
>
> #include <xen/const.h>
> +#include <xen/stdbool.h>
> #include <asm/cpuid.h>
This isn't needed up here, and ...
> @@ -17,7 +18,6 @@
> #define X86_FEATURE_ALWAYS X86_FEATURE_LM
>
> #ifndef __ASSEMBLY__
> -#include <xen/bitops.h>
... putting it here would (a) eliminate a header dependency for
assembly sources including this file (perhaps indirectly) and (b)
eliminate the risk of a build breakage if something was added to
that header which isn't valid assembly.
Preferably with the adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
