[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] x86/vtx: Remove opencoded MSR_ARCH_CAPS check
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 17 May 2023 16:36:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qxdf760ncPbPV6iltS8mo2G3uWsOOuPjPTs7ZIt5liw=; b=G9pw31PNhrqfzmeP4clMvo3/phWQyDSvikn0G4W1TpKn/YI31a4DFJ587hA1PU60PbcClS9qwlmLZVJQiL4gn2Q6ZkgSHmdeQvbZQIBEGYnOSp5Qsc6hzWzFlfnH4C2UUu6NxetGXKYk4o3lqckyYkq0ABB6yQVbQRfe2141FHT+511NdoPDSGartFJ+5llGF4up/OIFlaRWXpU385iacCDeSslzvWslDxKGRqYcsENCScUVcf6B+MEFlWXVZm0vCH5FegHOV7tgwteyPQxjcekhE6Uw9FYYwuJPDMJ9o0JgMx3x6vEM7kr0JWPVRQtw11EUatF9eBPANYmYPHP4uA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNkLk+xdINQxh/bMoUOl+lBOMmM1LtoHPgedHqhY8/447B2jpwCQw55MUVBhGI85oIg/9hYX+ut4yqoPSrWHTnBd0w53BfrdhHx08+ycLGLWrkFBA83YUvem8Gcg6jXAl0zkS7YW81sGWQSKp3oP8RqoL+FK3ylebbJN4dEGX6QrdhjSSfHhRcM6GYWhQC4yzK/0Hfu3ORcrv1awvQS9AFklNxew9lIIHIBH+RXUtjGNN5D0MVpDArVYuCmzYzvpg0l0aDYJXml8xP8FzKRBKg/SWGglbcuqZT3WA2+MLzl67WSQ7XbFY9LnUnZqXGbVCuwaI+59mbbHVy1ETvDSWQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 17 May 2023 14:36:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.05.2023 16:53, Andrew Cooper wrote:
> MSR_ARCH_CAPS data is now included in featureset information.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit, like in one of the patches in the earlier series, ...
> --- a/xen/arch/x86/include/asm/cpufeature.h
> +++ b/xen/arch/x86/include/asm/cpufeature.h
> @@ -183,6 +183,9 @@ static inline bool boot_cpu_has(unsigned int feat)
> #define cpu_has_avx_vnni_int8 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT8)
> #define cpu_has_avx_ne_convert boot_cpu_has(X86_FEATURE_AVX_NE_CONVERT)
>
> +/* MSR_ARCH_CAPS 10A */
> +#define cpu_has_if_pschange_mc_no boot_cpu_has(X86_FEATURE_IF_PSCHANGE_MC_NO)
... I'm not convinced that having the (unadorned) MSR index here
is really helpful. In particular to people not knowing the indexes
by heart (possibly most except you) the number may actually look
odd / misplaced there.
Jan
|
