[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] automation: Enable parallel build with cppcheck analysis


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Thu, 18 May 2023 12:26:29 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9bx2snVv4W3p8p2oYqTvwowFapIcPKqX4VTWPUzQsWg=; b=a9d5luVo9g4oRPm5BLpZVZBpQEFmfIKC15xvP0zqV7Kt14dVVOopxPoYW9euR8l4UwckbGL3SaDobST+T8Ban2xy17K6QU7tpnoGJDjzji67rnLpizFQzNM4WWQXuB4SFdl/1IchtHR3G70BI8hKO8mLh5Z6UBirlq+WYLCqibWp8y1PMu3T37dif1g0QpLTTY3W9eVoZ5IcdgwlYlAHYoaWdrY/6tY0Eu/aQgbg5rY4fbjvFUG5oL5QquEppLjlU1Z7ihG3u/B3GnHIaPvEFfTcH1nCSHGWIO8CU6o7NOD6tV5o0zgFydCJtKDHq6asnMdawz1GwxhJ98qLchEQmA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nWMZXRfk7HE8qxIWGk1XE48OHT5EImRvhBUbpti89dHrWsGjl2XKzZKGT8eQD6QBoi9+yLKLYFLJOIkhSnMuTTolK6/v92bNPjWlyJMWF+fjEkUWTbb1tqItyq6RIKxw4KOagq8VOS7+Ydpojv+E22yOC9sIDdEMBKDVUe2qu1fBntDPTbNAOiTObvdo3jStfnGxOoy5juYG3l0TVLgEu8CKrsI9RZoZKK8mltdPZoLEj+i5LWVdnyIogi3rSA56aayOAFA5kMLHh12G2RPfF+iiFvCLwX9RCs4tNgedpn8JoT9FKOIoiEarP4NJdaEBWOTKF7PchaKFZR18IoAygQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Thu, 18 May 2023 12:26:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZiYO0TSgWEhB91UKK6TnuwOVmHK9f9N6A
  • Thread-topic: [PATCH] automation: Enable parallel build with cppcheck analysis


> On 18 May 2023, at 13:24, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> The limitation was fixed by the commit:
> 45bfff651173d538239308648c6a6cd7cbe37172
> 
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

Hi Michal,

Looks good!

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>



> ---
> automation/scripts/build | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/automation/scripts/build b/automation/scripts/build
> index 9085cba35281..38c48ae6d826 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -39,10 +39,8 @@ cp xen/.config xen-config
> mkdir -p binaries
> 
> if [[ "${CPPCHECK}" == "y" ]] && [[ "${HYPERVISOR_ONLY}" == "y" ]]; then
> -    # Cppcheck analysis invokes Xen-only build.
> -    # Known limitation: cppcheck generates inconsistent reports when running
> -    # in parallel mode, therefore do not specify -j<n>.
> -    xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra
> +    # Cppcheck analysis invokes Xen-only build
> +    xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra -- -j$(nproc)
> 
>     # Preserve artefacts
>     cp xen/xen binaries/xen
> -- 
> 2.25.1
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.