[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/20] x86: head: add dummy prototype for mk_early_pgtbl_32
- To: Arnd Bergmann <arnd@xxxxxxxxxx>
- From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
- Date: Thu, 18 May 2023 18:52:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fiNVHMRZRgjKJsPlgxcLC7Vv43LhrmjaOmxRpNWnEm4=; b=kCtYhAvf9e17UsyTpGivThsh3pfaCbkGQPeJ44D0A1UTIwAq3yk3YevgX4aldGnJqE01iQH4G8mdee80Byvm0SXTIdLCNIL0sM/GJdMdTSn8J5msjIsrzpvvrXCoCdPtS8mefTqqgIYfJXgLbZKHf82Klg/Z6YoaOiaf6IBLj3yKtV1J3SOU3AL6PqONHcpfdMAUV42B3I/4wFsnDyPSHC0cgikUtIzXcwGRPDDRFfx3Kp7Z61nidFCIXz4yx8hVaQYfX60jzQafQRwA7sFD0OtUoZOUquVnk4uNgx/iB6FxQrJC8T/A+yl0F22hNTOQJG7UhfFmVsDbxTC2W2adzw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oTYS52vneRMF6B1SJtknomY8kON6EmrYXkIKJSOp+eIOu1hSkR99FazmKzgsz08dfSlNcDeAurcFI5C7T+gDjWNlycqVPz9fWzAWZHLTzVaW4O7qs78yyB1mKQQcLey/Kg0s8HKwgxSGnJE9KSQAc3t7vfxQAIKstm2dFgpTJrMKAGH6C75n6ge9SSbt+ViPw3re2EVgnqrGegltD4YCZh8ZzgLmOHKvJwwst+0EtcmuaijG1X2GdVmc9MODHPjtsQGLzYCxardnvwffPP84GfY+I6crKdD/ag8BrJJOZMfRcJaJWwMtuN1ywuijdzAVHpJMwtqC8wCoV8gZ1OugBw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: <x86@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Srivatsa S. Bhat (VMware)" <srivatsa@xxxxxxxxxxxxx>, Alexey Makhalov <amakhalov@xxxxxxxxxx>, VMware PV-Drivers Reviewers <pv-drivers@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Darren Hart <dvhart@xxxxxxxxxxxxx>, Andy Shevchenko <andy@xxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-trace-kernel@xxxxxxxxxxxxxxx>, <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, <linux-pci@xxxxxxxxxxxxxxx>, <platform-driver-x86@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-pm@xxxxxxxxxxxxxxx>, <linux-mm@xxxxxxxxx>
- Delivery-date: Thu, 18 May 2023 17:01:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Arnd Bergmann <arnd@xxxxxxxxxx>
Date: Tue, 16 May 2023 21:35:34 +0200
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> 'make W=1' warns about a function without a prototype in the x86-32 head code:
>
> arch/x86/kernel/head32.c:72:13: error: no previous prototype for
> 'mk_early_pgtbl_32' [-Werror=missing-prototypes]
>
> This is called from assembler code, so it does not actually need a prototype.
> I could not find an appropriate header for it, so just declare it in front
> of the definition to shut up th warning.
^^
the :p
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
I'd say, for the whole series:
Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
BUT apart from the Xen part, it's all black magic rituals to me :D
Thanks,
Olek
|