[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 1/5] xen/riscv: add VM space layout


  • To: Oleksii <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 19 May 2023 10:28:36 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mJqWN8/9JNox31rHkgub6+DW10pCtsL9LUee67rr7fY=; b=UI9HB3GuJYIEwWnOrid/kbJoN3KNPd1j2cYioVWCvjNyKQOdXXTbvgpjH7lqPSUtouhw0eoWjJKmszojR2dRk7ZYg6r8FB6uLu4EXsLd5SV8in4CR77voVNTesHCx5bC5HCodhkBg1VQi5B2awix9DeKEEiOhfezzNRmlhWRGh5kril2XgZnh4avzwttH1tukdzq4bMQfD/xqPDyn400ke0JGkon1Ar9zKksiLOx6Pgb7px1WUusABve39SwA2B1qeSst0yUo8pVF+gHK4BlIq1uLy7EQsPzvcF/PUW4qyv7tqpkXsh0tNU2fkuLiPfug5XCm8yKW3yhsoWzeHK43w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fodBSeiRzbAw97ILtqpoDHRi3TV+ET3FVyexVnpgwz7nO4Lv5vIt4cwmZKnx+Kzp1GyLTakhA33+zDWrjdhcX5askLIScvYVJ9gK2QD7NFkLljRY1DjHMSKr+W2UMx3KEPB6xgz10aa457tvnMV1qilQkq0GClJ7rUcI6vjJNomuiddjgiDwqWoLeXfFAOGhZgEyGCjlAhhMU3gdtsrvzfP12+VAEQ76gD/oc2WWQF+lLSOG/d1xIJd+wULoE5RT3Wx9A0+98Scx+EeOE93KOhnfkissCcYjoEPBYh7kEgNFmHnm28gTFMTDJr7tzQPMOVlsk80QapNkQ26mX5trGA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 19 May 2023 08:28:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.05.2023 17:56, Oleksii wrote:
> On Tue, 2023-05-16 at 17:42 +0200, Jan Beulich wrote:
>> On 11.05.2023 19:09, Oleksii Kurochko wrote:
>>> ===================================================================
>>> =========
>>> + *    Start addr    |   End addr        |  Size  | Slot      
>>> |area description
>>> + *
>>> ===================================================================
>>> =========
>>> + * FFFFFFFFC0800000 |  FFFFFFFFFFFFFFFF |1016 MB | L2 511     |
>>> Unused
>>> + * FFFFFFFFC0600000 |  FFFFFFFFC0800000 |  2 MB  | L2 511     |
>>> Fixmap
>>> + * FFFFFFFFC0200000 |  FFFFFFFFC0600000 |  4 MB  | L2 511     |
>>> FDT
>>> + * FFFFFFFFC0000000 |  FFFFFFFFC0200000 |  2 MB  | L2 511     |
>>> Xen
>>> + *                 ...                  |  1 GB  | L2 510     |
>>> Unused
>>> + * 0000003200000000 |  0000007f40000000 | 309 GB | L2 200-509 |
>>> Direct map
>>
>> The upper bound here is 0000007f80000000 afaict, 
> It should be 0000007f80000000. 0000007f40000000 is start address of 509
> slot.
> 
>> which then also makes
>> the earlier gap 1Gb in size.
> do you mean that it is better to write start and end address (
> 0000007f80000000 - 7FC0000000 ) of L2 510 slot explicitly?

No, not really. The ... there is quite okay imo, because of the differing
upper bits. I was merely pointing out that as you had it the gap was 2Gb
(from 0000007f40000000 till FFFFFFFFC0000000, leaving aside the ignored
upper bits).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.