Xen project Mailing List

Re: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...

From: Luca Fancellu <Luca.Fancellu@xxxxxxx>

Date: Fri, 19 May 2023 09:48:23 +0000

Accept-language: en-GB, en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gdBCT2ALX5Wxv5EZGQ6wrQqEMqsMT1tYY2k01sLMPS0=; b=DDBD5I/IbYqAGMuEtSlUoOBu9GemtXFdyZVCcR24Vt3GpiW/e1zFyxM+3oCh8fUtHHGMBVnlCtvHOzx6md+o2w7OcxnoftqsXIqRZSUomAOgxOoH0+CTlftRcsPmp1JAkEpq1VMhwNk6MX78z3DWH6efb7Ni7wyiVKdlxWDqCLNqdmnhLdFQSE/3pTHjlPzysTX498uCiaxQ+N9UhcSfWnt/i/ofQfPu47+94FMHK2Jf/77kI1pTzcYQMpHZJ4Q1kx6FXzef3YVIlz+7BGl0JfFPaUaNcpfjl/rI6ufGEUvsqDpfzohoDuzp5dJPCLHHHIWJ7BmQd+ncEAT9l6Q2nw==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N64MGL6x8aWxkr47NOizVmqrR0LVrncssg3Aog02CtgEIyA60EW0hRWa8Qb8IM0nMYe849pDAENkUdPWM/Be4j2g4ObeBAE0Dp5PTZX3PlXEJ/WTk/Eqv2AF2g+O9VKDgtCPc/n6Ka1MilAKkMxJsaM11VH3TkITolCTDfWGAHE+BGf9IWE+z20AYj6WYqhB9oPxR6mlAUoWBJytqcUz3EpQzNtXEoOgCxmiDyqjBqVr63Xa+mGNetNF6ID11gv62EnMLje/RYUck0Rsnkl6Y0a5r0ymrFrccOkSbhBp74D75SGvoqF/uKjRYpQsdeIzf0BKZWZLP6cD3lx9HlVUPA==

Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;

Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>

Delivery-date: Fri, 19 May 2023 09:48:47 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Nodisclaimer: true

Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;

Thread-index: AQHZfooyuAY6OgOAbESkC2BSWxnO0K9dtEiAgAOQFACAAAETgIAAA8GAgAAnyAA=

Thread-topic: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...

> On 19 May 2023, at 08:25, Michal Orzel <michal.orzel@xxxxxxx> wrote: > > > On 19/05/2023 09:12, Luca Fancellu wrote: >> >> >>> On 19 May 2023, at 08:08, Michal Orzel <michal.orzel@xxxxxxx> wrote: >>> >>> Hi Luca, >>> >>> On 17/05/2023 02:44, Stefano Stabellini wrote: >>>> >>>> >>>> On Thu, 4 May 2023, Luca Fancellu wrote: >>>>> repository in the reports >>>>> >>>>> Currently the cppcheck report entries shows the relative file path >>>>> from the /xen folder of the repository instead of the base folder. >>>>> In order to ease the checks, for example, when looking a git diff >>>>> output and the report, use the repository folder as base. >>>>> >>>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx> >>>> >>>> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> >>>> Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> >>> >>> I know this patch is now committed but there is something confusing here. >>> At the moment, in the cppcheck report we have paths relative to xen/ e.g.: >>> arch/arm/arm64/lib/bitops.c(117,1):... >>> >>> So after this patch, I would expect to see the path relative to root of >>> repository e.g.: >>> *xen/*arch/arm/arm64/lib/bitops.c(117,1):... >>> >>> However, with or without this patch the behavior is the same. >>> Did I misunderstand your patch? >> >> Hi Michal, >> >> Thank you for having spotted this, during my tests I was using >> Xen-analysis.py so that it >> calls the makefile with out-of-tree build, I’ve found after your mail that >> when it calls the makefile >> with in-tree-build, cppcheck is run from /xen/xen and it causes it to >> produce relative path from >> there in the TXT fragments, showing the issue you observed. > Ok, the way I test it is the same as in our gitlab CI so this needs to be > fixed. Here it is the fix: https://patchwork.kernel.org/project/xen-devel/patch/20230519093019.2131896-4-luca.fancellu@xxxxxxx/ I’ve updated my internal test script to test it on in-tree and out-of-tree makefile invocation. Hope I did not forget anything, apologies for the inconvenience! > >> >> I have ready a fix for that and I’ll push that soon. > Thanks. > > ~Michal

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.