[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/misra: add diff-report.py tool


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 19 May 2023 12:53:55 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ib20T4hZdR1RQXO2Snx3fTo7JI+hIMSkXXpI4ZrdNg=; b=hWB6sWj/PBhcA6TcD4FGQT+4R2Deh4C8Dvrc6sX+AjM3+ybCvk0At9DJ9Oz2aUJzwIWqFyzfNNdfwRG942iS6Xb3l9JNILPDfAWP7NlaSPVJTQh+fkZck2U/pKjbAMCh0P741Zx4mAamsmlN12MzcQ05/cfTEEyrVhhJ9MhSwy5NDxo6pq8o/tR3HvEHLr0jYw8pVla2aT5uNC2UhEygH/zy+mW+jQeriql6jj9f80m84hd2c4hVUIZpfpqYX92xgt4uE1z5my4TFBjtxPm1yf3HyfYH0KGIP/+ZGnNJk9QQzyimuAgM02R76J29CFpWGNvIa2yR+0n1/KLaSYd5DQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lgXT8LVcKp/r87nRK+8BKUJTdrRJSxn8GmB7Mo48RlN4cNTBM7Jm9DI9A+H6M7u3DWUh4OY9Q3+/iPE+QgTReIiaOwPdN4vyeZJuIOxVgYXxIKdNYE/H6CO2mORHPZlI97mnfF6gyuswEJ5yfwL7+ikaSzDJugP4myqw6QOfy7nANKI0/jnCQ14oY0oy/h4+vflUG3fBMKKoOMcCgAoKJJqWg+R57d2/XWITeuf3xpXOIjl1zc2MG2qeDBVSeEowTIdzbUSVfOq7J7h/d2yAJcQ2Azz0c9oL6TUABM5H9FkivWI9SRvf909Vcmu4IJ/cMNyY1OMi2sUFfwC1V5xYTg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 19 May 2023 10:54:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.05.2023 11:46, Luca Fancellu wrote:
> Add a new tool, diff-report.py that can be used to make diff between
> reports generated by xen-analysis.py tool.
> Currently this tool supports the Xen cppcheck text report format in
> its operations.
> 
> The tool prints every finding that is in the report passed with -r
> (check report) which is not in the report passed with -b (baseline).
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> Changes from v1:
>  - removed 2 method from class ReportEntry that landed there by a
>    mistake on rebase.
>  - Made the script compatible also with python2 (Stefano)
> ---
>  xen/scripts/diff-report.py                    |  80 ++++++++++++++
>  .../xen_analysis/diff_tool/__init__.py        |   0
>  .../xen_analysis/diff_tool/cppcheck_report.py |  44 ++++++++
>  xen/scripts/xen_analysis/diff_tool/debug.py   |  40 +++++++
>  xen/scripts/xen_analysis/diff_tool/report.py  | 100 ++++++++++++++++++
>  5 files changed, 264 insertions(+)
>  create mode 100755 xen/scripts/diff-report.py
>  create mode 100644 xen/scripts/xen_analysis/diff_tool/__init__.py
>  create mode 100644 xen/scripts/xen_analysis/diff_tool/cppcheck_report.py
>  create mode 100644 xen/scripts/xen_analysis/diff_tool/debug.py
>  create mode 100644 xen/scripts/xen_analysis/diff_tool/report.py

If I'm not mistaken Python has no issue with dashes in path names.
Hence it would once again be better if the underscores were avoided
in the new directory names.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.