[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] build: shorten macro references


  • To: Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 22 May 2023 10:44:56 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmLRf5Ck1L3hgbZSsPpT+g9LSkLIRfdCkOuhAtHXcUY=; b=PX10FujeAJexYOPuWcohP2jTXs5lf0igSQwF9okP1cPy7I3s2xP2RMsIbZALN1H0Iy3lFer61GCsd4/D6ojdq+nSntNNHm6YS1b7AS0cOXntw9TFgD61n9xzjTxhYVJPOiwhbxpcN+/gRBvh64ij83GBf3cT2UJcN9UapiNfyHI3xplDrJ51PEXOaMlfreByzcxEbhl6ZEpejPw5uOOnDMZprWEPeanE9KEBDGVBaPBDYhOSl7tD3KrS8qppwA/nnOw0BIjnHGhIAtSHqx0rTlRfsCPJSPBIZLAgXxs9ItczjtLg3seyb/Rvk/pOUkdQhrq5T27l74Jeqg29JQpZ+Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nOB5qiciEUwnwGPWrzBOFS6gv2mJ7GCagbh+lY6LHZKqroLVBhAXEuLy1Q5FkyabxAdMLveEog6VJyUQWkxPDl7orhp88U5hChihKEs7n1Ug3JCx1IzpkHN6uguLMzx/uZyNFNQyx5NVjao+XzNSjA5ZXiOOPfyTM7bvS9WPcIUiCDE8Ab8ug5AtF5HOZfYbym3eRO/Q+VHi26I1XIUiaulvfP4u9OPf8CldcEsRhyti6TRX4mBqMsmY7VTZvzeZ4HcK/2g9o2VmBSLx9VAb2LP/SXVfXnpDe8DjaujFoJZ4NliKnmwmF/WJ6gmlTMiNEWZ8yrwjmIerENay+DuI4A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 22 May 2023 08:45:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.05.2023 14:58, Jan Beulich wrote:
> Presumably by copy-and-paste we've accumulated a number of instances of
> $(@D)/$(@F), which really is nothing else than $@. The split form only
> needs using when we want to e.g. insert a leading . at the beginning of
> the file name portion of the full name.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> ---
> v2: Insert blanks after ">".

Any chance of a RISC-V side ack, please?

Thanks, Jan

> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
>       $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o
>       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \
>           $(@D)/.$(@F).1.o -o $@
> -     $(NM) -pa --format=sysv $(@D)/$(@F) \
> +     $(NM) -pa --format=sysv $@ \
>               | $(objtree)/tools/symbols --all-symbols --xensyms --sysv 
> --sort \
> -             >$(@D)/$(@F).map
> +             > $@.map
>       rm -f $(@D)/.$(@F).[0-9]*
>  
>  .PHONY: include
> --- a/xen/arch/riscv/Makefile
> +++ b/xen/arch/riscv/Makefile
> @@ -10,9 +10,9 @@ $(TARGET): $(TARGET)-syms
>  
>  $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds
>       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@
> -     $(NM) -pa --format=sysv $(@D)/$(@F) \
> +     $(NM) -pa --format=sysv $@ \
>               | $(objtree)/tools/symbols --all-symbols --xensyms --sysv 
> --sort \
> -             >$(@D)/$(@F).map
> +             > $@.map
>  
>  $(obj)/xen.lds: $(src)/xen.lds.S FORCE
>       $(call if_changed_dep,cpp_lds_S)
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -150,9 +150,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
>       $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o
>       $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \
>           $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@
> -     $(NM) -pa --format=sysv $(@D)/$(@F) \
> +     $(NM) -pa --format=sysv $@ \
>               | $(objtree)/tools/symbols --all-symbols --xensyms --sysv 
> --sort \
> -             >$(@D)/$(@F).map
> +             > $@.map
>       rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]*
>  ifeq ($(CONFIG_XEN_IBT),y)
>       $(SHELL) $(srctree)/tools/check-endbr.sh $@
> @@ -224,8 +224,9 @@ endif
>       $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o
>       $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \
>             $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) 
> $(note_file_option) -o $@
> -     $(NM) -pa --format=sysv $(@D)/$(@F) \
> -             | $(objtree)/tools/symbols --all-symbols --xensyms --sysv 
> --sort >$(@D)/$(@F).map
> +     $(NM) -pa --format=sysv $@ \
> +             | $(objtree)/tools/symbols --all-symbols --xensyms --sysv 
> --sort \
> +             > $@.map
>  ifeq ($(CONFIG_DEBUG_INFO),y)
>       $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O 
> elf64-x86-64 $@ $@.elf
>  endif
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.