[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] tools/xendomains: Don't auto save/restore/migrate on Arm*
- To: Julien Grall <julien@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 23 May 2023 17:44:07 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Peter Hoyes <Peter.Hoyes@xxxxxxx>, "Wei Liu" <wl@xxxxxxx>
- Delivery-date: Tue, 23 May 2023 16:44:25 +0000
- Ironport-data: A9a23:gGqTkqPLcdpTl+HvrR2Tl8FynXyQoLVcMsEvi/4bfWQNrUok3jwCn GpNUGrSP/mLajb8KNBzYIXno0MEsZWGytVkTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/rrRC9H5qyo42tF5AdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vpXBERz1 fAyEx42Vwqiob2zwrKKVMA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUoXTHZwMxRvB+ woq+Uz6Dk5LL4bPlQGV82CAg+7kwQnUBdI7QejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 0UM9zAnt6Qa6E2hRd67VBq9yFa8swIRQZxwFPw38ymE0K+S6AGcbkAGUzpAZdoOpMIwAzsw2 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi+QPu6lq0EiJFIw6Vvfo0JusQ2qYL y22QDYWm5UWqPMr24+A02v+mROK+Z3LTj8rz1CCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQQ3d6TN4QhB7JJKkWp4xDhlbHlkPc8fEdMCS B+C4FgBjHO/0ZbDUEOWX25TI55ypUQDPY6/PhwxUjapSsYZSeN/1HsyDXN8Jki0+KTWrYkxO I2AbeGnBmsABKJswVKeHrlNjeB7nnxllDqLGfgXKihLNpLHPhaopUotagPSPojVEovfyOkqz zqvH5TTkEgOOAEPSiLW7ZQSPTg3EJTPPriv85Y/XrfacmJb9JQJV6e5LUUJJ9Y0wMy4V47go hmAZ6Ov4AGn3yyYdl3aOywLhXGGdc8XkE/X9BcEZT6As0XPq671hEvDX/PbpYUaydE=
- Ironport-hdrordr: A9a23:YsrY8aAePEZ28CXlHenP55DYdb4zR+YMi2TDtnoQdfUxSKelfq +V8cjzuSWftN9zYhAdcK67V5VoKEm0naKdirN8AV7NZmfbhFc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, May 22, 2023 at 08:34:52PM +0100, Julien Grall wrote:
> On 19/05/2023 17:24, Anthony PERARD wrote:
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index 3cccf41960..0f0983f6b7 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -517,4 +517,17 @@ AS_IF([test "x$pvshim" = "xy"], [
> > AX_FIND_HEADER([INCLUDE_ENDIAN_H], [endian.h sys/endian.h])
> > +dnl Disable autosave of domain in xendomains on shutdown
> > +dnl due to missing support. This should be in sync with
> > +dnl LIBXL_HAVE_NO_SUSPEND_RESUME in libxl.h
>
> Quite likely, a developer adding a new arch will first look at the
> definition of LIXBL_HAVE_NO_SUSPEND_RESUME. So it would be good if we have a
> similar message there to remind them to update this case. That said...
Probably true, I'll look at adding a comment there.
> > +case "$host_cpu" in
> > + arm*|aarch64)
> > + XENDOMAINS_SAVE_DIR=
> > + ;;
> > + *)
> > + XENDOMAINS_SAVE_DIR="$XEN_LIB_DIR/save"
> > + ;;
> > +esac
>
> ... I am wondering if the switch should be the other way around. IOW, the
> default should be no support for suspend/resume. This will make easier to
> add support for RISC-V (I suspect support for suspend/resume will not be in
> the first version) or any new other arch.
Sounds good, I'll look at that.
Thanks,
--
Anthony PERARD
|
