[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 07/15] build: move XEN_HAS_BUILD_ID out of Config.mk
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 24 May 2023 08:06:44 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B0VMxCLoQQPUr46kFOSiOFnCB4xFnkONu7nZ74zTObo=; b=Xh5IxK/qJMm0PSL1PsLpHVwm337yPmOSyQbDe/mQiRS4c2jWupH4kq+hNOIO5a3E1VgGyOUGkmwwyWHB9An/y3cW/XsBKq4Rea5IDtReSrHFC5emZ2sv/WYh3QSCjidz5p1gr4QDGU7/NGdAniccM+PsDQwBP3rHfsVDyV8aaRWnmFChN7AgQ048a8DW6Bx1duQ/cXrppwGedFl7Hx/aOAIYZHjXRisvsJjPk2lQHHFyPzu+k3zMigQvMXG09SqcRyvzTUdfhXWTXGWOTRMKZkEKWl3CiMRA4lrm5Nwl2sSuuhx2dj0Rq7f2BbJQOSt46/Xrba+q11XnsNJF5Im7Lw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=geyn6l9T+apqosIKcCApIA6FieVvvUosXjKuez6ALBVZGytn0ixFznv7OEaveqg4W67KKcnNoc+qrwt9HOXbiH1v42wHJ5Co0YknnOa3mgxt8SdnL1lUl+pp6G+GfIUw4qtYJczo8h0586q0PZhK8D4bIVHjVInGjknbM44aunTogw3SJ6HFTP6RfVUoZ1uSTzlH6VN1hODIlSX6IBEyA2CFQHhaebp8dUB+LmUpEJl0Pu2CuN/ifdzPLAlhztx1/JAEEkic9Fa3do18Rw2GtPC2wggjKDLk6qafBQ4oZlTwDGOrq3uiwlrshnzcE1NAUVHQ7T4YFzDN5JfCqp2Ycg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Delivery-date: Wed, 24 May 2023 08:07:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZjZUa7+Qnm+197EOtmkiEO2C8y69pEiUA
- Thread-topic: [XEN PATCH 07/15] build: move XEN_HAS_BUILD_ID out of Config.mk
> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Whether or not the linker can do build id is only used by the
> hypervisor build, so move that there.
>
> Rename $(build_id_linker) to $(XEN_LDFLAGS_BUILD_ID) as this is a
> better name to be exported as to use the "XEN_*" namespace.
>
> Also update XEN_TREEWIDE_CFLAGS so flags can be used for
> arch/x86/boot/ CFLAGS_x86_32
>
> Beside a reordering of the command line where CFLAGS is used, there
> shouldn't be any other changes.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Seems good to me!
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
