[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: un-break build with clang
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 25 May 2023 14:43:59 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53IppQY8P00JUZOEakZOn5qLBVo1mulM6P3qTzEkU3E=; b=JNps74dxtQDk/afS8DlQ7oDXHXWfOevYQk0blHpLn8VaogllHh0ETQQzdg0X5F6CVf19B1Jx5b5KR+mxARQR0KV8yIllRkxcT6DrO3DIXB/MB3ARTlqqRq7ddK774y0xm8Ws7m12K9vqt1JsW64WhbLAjGJwL/kihBjBU2Gm4BKkZ6vwVVV7cgyFVnMNOGsf+X3gXj7OEU8LAcFfgQcn5yTzRKUThDXBHiY2EOEui5ZxsA+C7pcYdP6ALvRRa+kSwwZIca+lTsEGm8VRhpDnA8kT83zE8Ro8KuagszANiKJ60XTKJVIz6cMMmr4bbOxq/ejmi9LpRgvRIZ2KsNDfEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TgWISFYeUtJBes0bFYE7R/AyboaVBXe+PsBVo6XGEEecYVET4P1Vg2c4DhpO0mdYM1o8wwrkg3FMa1D98WxmdzHms8kzler2s2HDsv5RKoKTDUD7RrvoCD3DPgddoX+ktWGdxOXH+hbKnMYPwgEpxabdxw8xvrtd0nfmHwFwmLWDPiqRddTgECh+MKzIkJXpIY7GMf1u64OLGp7jRxMZGFVw03JeBYpZ1DO/sebXgVfslugHRJdkteIIR9xu9EJ/wLDmLQ8FzjfdNQZEA3j9FVaoVRnXi1t6eQ42aYyq+RUxUK0+3Skg8rT5xBXWKxWDybe1ufieXVvWoZ+bMJovpQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 25 May 2023 18:44:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/25/23 14:05, Andrew Cooper wrote:
> On 25/05/2023 6:51 pm, Stewart Hildebrand wrote:
>> diff --git a/xen/arch/arm/include/asm/setup.h
>> b/xen/arch/arm/include/asm/setup.h
>> index 38e2ce255fcf..af53e58a6a07 100644
>> --- a/xen/arch/arm/include/asm/setup.h
>> +++ b/xen/arch/arm/include/asm/setup.h
>> @@ -168,13 +168,13 @@ u32 device_tree_get_u32(const void *fdt, int node,
>> int map_range_to_domain(const struct dt_device_node *dev,
>> u64 addr, u64 len, void *data);
>>
>> -extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable);
>> +EXTERN_DEFINE_BOOT_PAGE_TABLE(boot_pgtable);
>
> The problem is using DEFINE_$blah() when you mean DECLARE_$blah().
> They're split everywhere else in Xen for good reason.
>
> But the macro looks like pure obfuscation to start with. It should just
> be a simple
>
> extern lpae_t boot_pgtable[XEN_PT_LPAE_ENTRIES];
>
> The declaration shouldn't have an alignment or section attribute on, and
> deleting the macro makes the header easier to read.
This indeed makes much more sense. I will send v2 with simplified extern
declarations.
To clarify, the definitions in xen/arch/arm/mm.c are to remain unchanged.
|
