[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] x86: Expose Automatic IBRS to guests
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 30 May 2023 18:31:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xPupXtiOvjibfucvNUqXFdPuf+q3cQrntE2/+FNJ+Eo=; b=gSunSclFZYfLmWuDlXEgCPTGj08cH2FsT2jDN8Tnhpt8hw1wWDbEmQQSB93WuZjkOvTqkE9Gk+MriQg2fjk45qQTQrWPIHRz6k4y3yK/ykiMWek+xpLulS1QOH31EVaw62sCeRWHgZ2QwQDwZPQfzP7tWLK3qKuo5o/9b+AUvDochU6hlHamAsepKcuL9XX3hCcTY4wyRIl0gWmTITz3hg6rud+SMzOdwQL9OoZ/c6CDfzsexVkHVFaWOZweoN88xcuHforcLeEP/xlP/aHRisbMccJhD9gQt2uWtv6o3641KrbjGyPYjmTAJpo5i+2hBUadu+uVybq7TzHF7lFgAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=doBwt3EtG+e2cThbT3n8dDguWQFUNep4vTQAEa9CW/thLZRSG1P1DwA8c3UCTzGZLmJgl6x1UDh+xqxp42MYxTSTsimKyIu77uxpsdfQ/t1Ba2eg14NRUrgVfcTrMDvPGcZgOtwzmkotXJmDFhYDegQ2QVTbzB0i0ci5n8bzEqDXcLc7ItufrnOHsXwkuZfiYJPMAVd/gQy7lG640moi+LnSQdcPotbYD12sLZIpdcUYugIRl4vub5mh72WDemqnCjfNPavCIsb6fU+Q/YBbpCO8GXO+WLOiGoh1v3/XQUt42xZ0zAhlOhdgwAszeRTpHAqVx429cle6pT7iU8+KUw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 30 May 2023 17:31:35 +0000
- Ironport-data: A9a23:JvbunKwUKD20aOIwVEh6t+f3xyrEfRIJ4+MujC+fZmUNrF6WrkVVy GAbCmCFaK2KY2bwctkjbozj9k5TuZWHy4BgQAA+qiAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EsHUMja4mtC5QRjPqgT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUdl6 /k3eWA2VCmarNCc5quLQchplst2eaEHPKtH0p1h5RfwKK9/BLvkGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVlVMuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAdlOSObhp6ICbFu7w208JBpHVUqHucaehUqSdOkCd Gwv0397xUQ13AnxJjXnZDWxpHOGtxgQQd0WDeQ+7AyPzYLf5wGECi4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9L2UPeCsFRgst+MT4rcc4iRenZslnOL64iJvyAz6Y/ tyRhC03hrFWhslS0ay+pAnDm2j1+cePSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOvBCyqtWNEEvWNSIg==
- Ironport-hdrordr: A9a23:9TY7naqybOV2RnaP4LoVdkIaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30/05/2023 2:58 pm, Alejandro Vallejo wrote:
> Expose AutoIBRS to HVM guests. EFER is swapped by VMRUN, so Xen only has to
> make sure writes to EFER.AIBRSE are gated on the feature being exposed.
>
> Also hide EFER.AIBRSE from PV guests as they have no say in the matter.
>
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I've committed this, but made two tweaks to the commit message. First,
"x86/hvm" in the subject because it's important context at a glance.
Second, I've adjusted the bit about PV guests. The reason why we can't
expose it yet is because Xen doesn't currently context switch EFER
between PV guests.
~Andrew
|
