[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] x86/smpboot: Disable parallel bootup if cc_vendor != NONE
- To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>
- From: Tom Lendacky <thomas.lendacky@xxxxxxx>
- Date: Tue, 30 May 2023 16:13:52 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q6toczsQlbG1rkzV+nTlLC50bGtvscaDHUpYbpwR1Xo=; b=Pxhf1O1qXodg7ZnVUHOBMdvfQOMzKF82odyf1kuFpO7tLm6SkTXsXv9sGMyNTOgbwGcJGPUZltdFcx0MhYAvESNN6WVhm1pOkI+GBhLDDubfKDzIETR44Ti6bDwRJIhaVUdGOFUPaJBbtvCZAIU4VcIEQyRwWXalsShNQYAC3nhJE9v+GaVLvxEu++nNnjfP4sJRo2XwDecDdZeYq41pYBvxzDnrCSISqf77B2dyKT54pp+oUBH+fe0cLR6uin+75WkqnoOv1XzjV+TR2shvUzSVNNxJs0n40Izp95VMmJ7eLm6h1ac4DmtRF/hx3STnMtWL+COFRswreIP9Li2hUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kX3oYEn1eJZW+MdPVb/T4I9QBTeQl9DLbkUEaWkzM0EFqcwYaanjKTRv/e7z+I9GvZs66wTYEHIS66AJnvO7+O+4E4+CeSobikUCqRtQOKMYfonLdb3IO1EEokGRsWchAt/Z0x1yB0/+8hqSIK+I63CjTS3qyetf2h7wRnyOLrrLpdE70WBi/EMZHCKO5TciHWlAmi3HZgRn5cFUYkibo16juUWHuSOKMzO3rQnx/khUxXqkkntFdatFyCu9wz7e+lINEQvZg4jgt0v1dGL8vckFYE2ptzN758yobpkLV4ijqQqIaplE52fqXz68QDhV5D8wC7tjCcWS0jYZe19Hxw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, Arjan van de Veen <arjan@xxxxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Paul McKenney <paulmck@xxxxxxxxxx>, Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>, Paul Menzel <pmenzel@xxxxxxxxxxxxx>, "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>, Piotr Gorski <lucjan.lucjanov@xxxxxxxxx>, Usama Arif <usama.arif@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, linux-csky@xxxxxxxxxxxxxxx, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, linux-riscv@xxxxxxxxxxxxxxxxxxx, Mark Rutland <mark.rutland@xxxxxxx>, Sabin Rapan <sabrapan@xxxxxxxxxx>, "Michael Kelley (LINUX)" <mikelley@xxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 May 2023 21:14:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/30/23 15:39, Thomas Gleixner wrote:
On Tue, May 30 2023 at 15:03, Tom Lendacky wrote:
On 5/30/23 14:51, Thomas Gleixner wrote:
That aside. From a semantical POV making this decision about parallel
bootup based on some magic CC encryption attribute is questionable.
I'm tending to just do the below and make this CC agnostic (except that
I couldn't find the right spot for SEV-ES to clear that flag.)
Maybe in sme_sev_setup_real_mode() in arch/x86/realmode/init.c? You could
clear the flag within the CC_ATTR_GUEST_STATE_ENCRYPT check.
Eeew.
Can we please have a AMD SEV-ES init specific place and not hijack some
random code which has to check CC_ATTR_GUEST_STATE_ENCRYPT?
As long as it's not too early, you could try sme_early_init() in
arch/x86/mm/mem_encrypt_amd.c. Add a check for sev_status &
MSR_AMD64_SEV_ES_ENABLED and clear the flag.
Thanks,
Tom
Thanks,
tglx
|
