[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] vPCI: fix test harness build
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 31 May 2023 16:02:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGqqPUSwVl8ZXQWXWeiK1coGaeSXoF+U0q1t2zckZSg=; b=jLRkeSH+sEvnoDbaBN6M8LHzcjTs05IW+43P0iOlnC+qFHdeShapPg8S3Wq/SbVZ1gk+VQu9CR9wjRGZNN4ZhHl82XxNMGoKE1k6IyB+PMu8GqxSdpsoAMTKnBkBpExv+tiAIU8P4+JJwMr7id6ZtPFAu3s5zWzRZmYZbDpkoKNwe7eACVvq98CbqW90ieUJ0L5fM5agJznsEn4DiEzaWZLKj0p2agsB41QzD+zuVcTJldMzoIgitoWHrhl8Dq9IMIq5w183RYGwPGnVaFP1ozUNO4WGIPqEwjU6Qa1AzFKJU1iIAlBiLrrrC1RhJ/pEsESjamPJ61AqbOPX2mKSLg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfSkkMmMNSpMIC2r+dgDKEQrgKp+j9A2IKlgnGRbZ2vvyLGt6jlfXioH/vPTWvHWkBPIQVx9psezbn6piXwq1IfD6+sabgRU5qcPDmS8/UO+ZI1vk5e4/U9jjzXJPF+XkmYDIb3kvbrU1IVE7HmWQzcbyL2kR/77+ra7A0gMOI0FTJ1A9XaojBQS7ZILbrc4S9IJhb7fni7YJvfT6qVQDX7xBBHGSfFNGCOMI2w7x2xJsUyaLkp8qD7rFmXkulHFBSeDI9oVFpws42NaJkWgbE4ooFyAePschRZd8sD1atUQ9eMIN+Gf+YQxJ2ldbevlXV77aNxJWe5nK3hqINyqHg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 31 May 2023 14:03:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.05.2023 15:51, Roger Pau Monné wrote:
> On Wed, May 31, 2023 at 03:19:56PM +0200, Jan Beulich wrote:
>> The earlier commit introduced two uses of is_hardware_domain().
>>
>> Fixes: 465217b0f872 ("vPCI: account for hidden devices")
>> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
> We do rely on the compiler always removing the call to
> pci_get_pdev(dom_xen, ...) or AFAICT that would also trigger an error
> as there's no definition of dom_xen in this scope.
Not really, no. The stub macro itself discards all its arguments:
#define pci_get_pdev(...) (&test_pdev)
Jan
|
