[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v6 02/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree()
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 1 Jun 2023 08:58:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nTF8SE41U7AikeKtvWn9Dua2dAKfj1zQOj57L7NbJQU=; b=AUpM26WkwrNxA/DgP2Vru1VfmT4ZYkpHSXqK3yt8bMyutXHQUddvfBbv9zJ2jKVe6KNYXmTmJOo/JX9OMIR3URt0KVS3q1eztOh9AYZSkne19plYLTzsrnjY4U3AKTa7TSXDITGHzLhwaVXSHswwesUyTY6IsbfyLBtmPrpU8V/U52t+Jq6y8KPRPieu7AeCIWLp9+CGmpWjeqTtrZoftv7wDoIYMlsC7spuc2Pcnu8nJfbapklKkXDVAKdOBN8yhyOQWrvej9AwfJ11D5yF6IexwcdhPnnGBU4kgOegJx11W+62LCcWbaAr94LCm3TgtQ0D6OtHZAzl9iLbFet1tg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4ZFAb17r9jbXM+98GQsFSM357oJtNJZ2PTNRyHTarS/NBHO8lk9XeuWrQwmj4zmw9JXf7+CdHRv0VwY6BzrPdUyErNlxvtNzv3DfiqAkb6j1l11tEI1+J56uKJJ+145tC8kBTS3bHnHuu18bJKkekESTbsXlmC5k751Dehazj6L8zT/mczdVyzIhqoVFHXr0rNMzdgIOgSWN1U1OQwtwm484tnekPSHgLdSXv2zHlvHfUjQ2jSGt/xQZTVpuiKgMtJzgdK8TvGaXPV9Hnha3l8UdZdwyXGuLkiOa6GEZ5EkxMuM+F1+mAZsH+GrP6Svnop105Y0FnGIPjE/+sWOlw==
- Cc: <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 01 Jun 2023 06:58:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Vikram,
On 31/05/2023 22:32, Vikram Garhwal wrote:
> Hi Michal,
>
> On 5/5/23 2:38 AM, Michal Orzel wrote:
>> On 03/05/2023 01:36, Vikram Garhwal wrote:
>>>
>>> Change __unflatten_device_tree() return type to integer so it can propagate
>>> memory allocation failure. Add panic() in dt_unflatten_host_device_tree()
>>> for
>>> memory allocation failure during boot.
>>>
>>> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
>> I think we are missing a Fixes tag.
> Like the below line?
> Fixes: fb97eb6 ("xen/arm: Create a hierarchical device tree")
Please check docs/process/sending-patches.pandoc
The correct format for a Fixes tag should be:
Fixes: fb97eb614acf ("xen/arm: Create a hierarchical device tree")
~Michal
|
