[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/vPIT: re-order functions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 1 Jun 2023 11:17:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGL5vgFCFkEo1TBsGjhXa0fOE5fjQn/XNu5TL3fgRpw=; b=U+rgKQOI2Qg4L4wNUpflV1ZqkG0+llwRMzEqocWJkU3o5Bgk/qE4FDD8Yb0YyK4g5Qui80jODd0qJ7bgQmkqqBW1kqFUbyt9K8lp5a3cwJb4htzua6GmBZ6FzyVk9y+QNucz4ykP92n/Frhx2lFiocZwdR5Aggs57eLqPM+kHK+2YCYfF7L7W7Z+RuE6Qbqtq7hl5EMP8Rv0sORMSxwMS54NXXdETXbcATlaadZFqzoY1JbGYsBKFyT4gXvtVY5TEpDaGjCZMuI73XAhOk/l0Kiqmy8tj5xBJD5mby4QQmAvIOym2SQheJgkhtPRJj+944fiFUUG4t+skYL8I+DHNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TZa1YI6bpyAitJJUWW2v49X1KhWoCIYiqJpckculC7fUa5Y4hdMe4pSNDzk5YyvxySjpjUyx4DhU7gDiI/CkjjIiEJlXiXnWFIQSf2CuulbIPNKJHPDSTIpU0d+S0sxN8ksMgLocvVAO7Grru9sk0KM0Y+haoGKGT4zHYD2a2FfK/9s8C9DKArvSCjrQh31ufwPYzhdNlXXtJGa2T3CP+Sgdlnf2xkmlnpZ19F80GdQbEdkO25KTq6ZdEaggGLbbnHjUdBElx85HObUVR+c8l/cStAVtigJleeGvmnuF0BgxWrydxtC6hogmLm+ctTzdSRqHfQq6LN3p2kyrRdeK7g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 01 Jun 2023 09:18:12 +0000
- Ironport-data: A9a23:gwpj3aqzWogI6My/V0Qp+I8QlV5eBmI+ZBIvgKrLsJaIsI4StFCzt garIBmGOfeDNjaheNggat+x8E0C7cODm4VnHQM+qHxjRCMRpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GtwUmAWP6gR5weAzyBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABEJaxuAgeWJ+quYb85sufgeN9HxJbpK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYSFEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdtKSeflqaYw6LGV7kUzBTsvZ12Um6ma1VaPYtVcD 1Ik1QN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zvpd81hxeWFNJ7Svfr3pvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:Zf6PqqN/C3dKEcBcTmKjsMiBIKoaSvp037Eqv3oBMSC9Afbo8f xG+85rqiMc6QxhJE3I/OruBEDuewK/yXcY2/hqAV7mZniahILqFvAo0WKA+UyEJ8SdzJ8/6U 46Sdk3NDSYNzET5qyWjGfYc+rIguP3i5xA7t2uqEuFIzsaEp2Ioz0JbjpyRSZNNXh7LKt8MJ Kd48pBqX6EeW4LB/7LTEXtCNKz2eHjpdbeehgBCAcg6A6SyR2VyJOSKWnr4j4uFwpVx7Es6G 7ElBG8wJ6CnbWU9j/wvlWjmqi/vrPau6x+7Qi3+7tlXgnEu0KRTqRnRrGYuzgxydvfmGrCiO O86ivIIf4DnU/sQg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote:
> To avoid the need for a forward declaration of pit_load_count() in a
> subsequent change, move it earlier in the file (along with its helper
> callback).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Just a couple of nits, which you might also noticed but decided to not
fix given this is just code movement.
>
> --- a/xen/arch/x86/emul-i8254.c
> +++ b/xen/arch/x86/emul-i8254.c
> @@ -87,6 +87,57 @@ static int pit_get_count(PITState *pit,
> return counter;
> }
>
> +static void cf_check pit_time_fired(struct vcpu *v, void *priv)
Seems like v could be constified?
> +{
> + uint64_t *count_load_time = priv;
> + TRACE_0D(TRC_HVM_EMUL_PIT_TIMER_CB);
> + *count_load_time = get_guest_time(v);
> +}
> +
> +static void pit_load_count(PITState *pit, int channel, int val)
> +{
> + u32 period;
uint32_t
Thanks, Roger.
|
