[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] iscsi_ibft: Fix finding the iBFT under Xen Dom 0
- To: Dave Hansen <dave.hansen@xxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 1 Jun 2023 19:05:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pi7uD2ND6XW8mRc8inwQz8CFapHmqDbZDow354ZJhg0=; b=ItIKHk6CJ/hxpZ6IfcyPHI2/vbz6YCM2wAg1fzhThebRMV6N8RpJZGP9/KtXMwfD1gjQqul5zvIX5r1/wiaofDk1WLL94g+IJWnGyWHP47tHXndpzbhkbyAEZR8jpcNRjYU962d1yxUl5D/C8EWWc8bbV7etAkyN19EpWGkZd7wdKTwS7EoXI4dZAn4WPjCbt3QOl970T+5hSwWtSpiERyX5SuJZOOfvwBZ+lTorYlXvU9b3E5feXdBf3CvRAwtqkNxXrMCVNRLsRNf9gKbzCaUfZEZ/7wQ4ucHTcVGCofW3TgAv1bD1F96JNyOgoPuBzTpMgV0VCnbmFDp0p8xiMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ELI7ns5NGdVDGPhvN2kGrigykKbza1J0ZRAjyrpY7zIb9+f2JlEv4r53fM49yMIaJUmgckraAh+8sBJI9gzZGmD+kNfO3qgfQX/Tk9nURIH0pO5rx08CRupIWGrXLJ2Vg7e7u0Hypj72S/l9ju1ykgAxT7K5YVIfubERFxNzan8CgCh3xJY+w70oSVtJxr6Lbz1rtgR8+l88d6hg4HdV64L12rpc/Pct0n2KFzNYv+NdNOPK6ZxYyKf7+Xx8GK0oQey3RhXaV9ml2d1JBFHUjDof7QtdlqD5LOBWHQCT/CydqpQSufUcxz6490k89JhwLoIi8y30fDRfoyQ7dQ0P5Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Peter Jones <pjones@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
- Delivery-date: Thu, 01 Jun 2023 18:06:30 +0000
- Ironport-data: A9a23:00/djK1yPK0rR4PlEvbD5dNxkn2cJEfYwER7XKvMYLTBsI5bpzcCx jAXD2rUOviPYjaketgga4m29R8BvcXVx9IxTAttpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gJmPKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfOjoR6 sMoNW00RDODgu6H34niQ7Jtv5F2RCXrFNt3VnBI6xj8VK9jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6Kk1MZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiAdxNT+3oqpaGhnWy+S8JLDhIdGK0rN6o0228Qt92F GAtr39GQa8asRbDosPGdxGxvnPCvhcaQNdWO+w89AyJjKHT5m6xAmkCUy4Ea9E8ssIybSIl2 0XPnN7zAzFr9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIa3hNDoHTD7w xiRsTMzwb4UiKYjy6q/7XjDgjSxuoLOSA8loAnaNkqg7wV2Y6a/aoCo4ESd5vFFRK6TVnGIu HkJnZjY4O1mJZ2EiiHLQOwLB7yvz/KENiDMx19pA5QlsT+q/haLbdAOyDJzPkFkNoADYzCBS E3cowRK/7dIIWCnK6RwZuqZAcMwzLOmEs/5TPfKddlfSp9rfQSD8WdlYkv493jvl04hioklN JubeNrqBnEfYYxkyzysTus10rIxwC06g2TJSvjGIw+P1LOfYDuZTOkDOV7XN+Qhtvrb/0PS7 spVMNaMx1NHSuribyLL8IkVa1cXMXw8ApOwoMtSHgKeHjdb9KgaI6e56dscl0ZNxcy5Ss+gE qmBZ3Jl
- Ironport-hdrordr: A9a23:HmAbsKA8Bb4N6pflHemH55DYdb4zR+YMi2TDtnoBLCC9F/bz+v xG88526faZslkssQgb6Km90cq7MBHhHPxOgbX5VI3KNDUO3lHHEGgI1/qA/9SPIUzDH9lmpM NdmvhFY+EY1WIK9voSOjPIderIHeP3l5xAWd2ut0uFkzsaEZ1d0w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/06/2023 6:08 pm, Dave Hansen wrote:
> On 6/1/23 09:57, Dave Hansen wrote:
>> On 5/30/23 08:01, Ross Lagerwall wrote:
>>> Since firmware doesn't indicate the iBFT in the E820, add a reserved
>>> region so that it gets identity mapped when running as Dom 0 so that it
>>> is possible to search for it. Move the call to reserve_ibft_region()
>>> later so that it is called after the Xen identity mapping adjustments
>>> are applied.
> Oh, and one more thing:
>
> What is the end user visible effect of this problem and of your solution?
>
> Do Xen Dom 0 systems fail to find their boot iSCSI volume and refuse to
> boot? I take it after this patch that they can boot again.
>
Yeah, this isn't as clear as it could be. In short...
The iBFT suffers from the same problem as legacy ACPI RDSP. You've got
to search lowmem for a magic marker to find it.
Xen dom0 is just a VM with root-like perms. Anything it wants an
identity map of, it has to ask for. And because dom0 is commonly
sharing ownership of hardware, it requests identity mappings for
everything reserved in the E820 table.
The consequence of not having this patch is that if you try iSCSI boot
under Xen, dom0 can't find it's filesystem, because it can't get at the
iSCSI initiator.
~Andrew
|
