[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v7 12/19] xen/smmu: Add remove_device callback for smmu_iommu ops


  • To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 2 Jun 2023 09:47:46 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6W3xd8aKCskwlf0gGkwrberJSoufyL1gBa5ylXYbY1k=; b=JBeS7qwWHmIeFJPWynK1XwfNPudLyWFKRAGm4iej+D7El7yYZNEGtXi+MasYeRPlHgDRrq6d1i9Wkmnv/FIPY3oBGA1YQaxoBMCk0ZkuvthzfZzZ9mPMHniSneOBeoJS6Y6IS96vtPW5K64krq3RNmhKugthOi9Fxn/3KbYkgJj/aWrVdfKz8HmZCIIEx7Mr7n92bo7Y8oHYDgoTwrNXpN9OeS8UZvUoXQhPm41qHpDvI0uKwebiIEYdxh8FhArcT/hodIs2mn+5jjSGCXgfAwKXVqe/KFV0Bju6axcDiNtZ8O9Tl/S9znEC02jlTN/Aw5+mcVIx9QKOXKOqy5H+XA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a0uLodyphPTM8NsQhS9SuzOYfKCRGOG568e0i8ezDbmNKmYprP3PgnPKKWvs1++0TT+Wg5EaJSRJppdTP1j2NlDK5IL6Hq9XwzlmS8BswG8tbNCLKxhquNYpOvw6JDlXhh+rhMnZ80fnXrnXe5JgdZxxpkAuDmvc+FpNVY/FZKyaWu1SgPwePyfHO69nYsOHzv5tB9mdh0rj8v/cfwBblYXyXW1sjavtoJxkUpjVNGYR8yEMYAbjOHhgQCHYarKYvPnMYBJqE8XslPq9gGYeE660hN56irhHMCXEvIWr2YmupKfWzTgcbbYQpoccYO8PhiRG1sZ5zCMA2A8vRs0Trg==
  • Cc: <sstabellini@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 02 Jun 2023 07:48:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 02/06/2023 02:48, Vikram Garhwal wrote:
> Add remove_device callback for removing the device entry from smmu-master 
> using
> following steps:
> 1. Find if SMMU master exists for the device node.
> 2. Check if device is currently in use.
> 3. Remove the SMMU master.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
>  xen/drivers/passthrough/arm/smmu.c | 59 ++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c 
> b/xen/drivers/passthrough/arm/smmu.c
> index c37fa9af13..fdef6e7a7d 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -44,6 +44,7 @@
>  #include <xen/irq.h>
>  #include <xen/lib.h>
>  #include <xen/list.h>
> +#include <xen/iommu-private.h>
Please list the headers in alphabetical order ('i' before 'l').

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.