[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v7 06/19] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB.


  • To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 2 Jun 2023 11:09:39 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qN9yENbE+BYxlLVy78NjiG3zoUq6RGsuqPWFbHNk+k0=; b=LekT8HUEnRqla96BpeMw2CGSdR9uca6weeMGRqVkVJNV8zLl2mQRdNK1lzNvKDtDfolUeKlyR+PdQwJeicSvDhN2wrSTCMexpsW7nzDuqG/eRG43VmmTqvGNhi6yDYyUivc6iEYSuKdJfGGzhfvHc/8U0a0ge0BBA8QDSlSryC1jGND+qPniU4JGjr6TquIQ57TJifWhBtvwgMKvmRwRaQX5A9Iy72CvqXxzXKnQAunrSKzTpbDbz32HSGt/vJUQezLaR8Rfij8i/V5US4HlaUeDYC9eQu/PYlCiFJtvJ9oYiNgne6u3D5lCfjGdf8xImbTP5Opoo8c3DyPw9Ug2mg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NV4fd0xJkprRTIAXTMxxkfpyQafB0RAFo5ZzV+YGHMcVC6suH55hrhwkb0kLB0kizrJpkFkDTPlAPl8Kncqig3aDBa28DlIHoJ2fWVlOxP2LpVETO+QcS0OVIEVUOUILAU7Vz+SYGBy6b/S/VeUnxDgCiLKiLoo0i4JoSHO5i+kV8s/s8H8oVFt4on0iIwBbVBAcyTgC7croT8OumbZp4uHfdSmE1wTlEutfOU/ML2Ex2Bn9yYMlbXW1m6Ky9P2+13mMhv7C5Gfrm0KRAHWDDnI8LJzdfKPmDmp45QJdfAL22N1pIiTARUggXxhgImn77bO+jsNPPQ+FxsKP+S0Rjg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: michal.orzel@xxxxxxx, sstabellini@xxxxxxxxxx, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 02 Jun 2023 09:09:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.06.2023 02:48, Vikram Garhwal wrote:
> --- a/xen/common/libfdt/Makefile
> +++ b/xen/common/libfdt/Makefile
> @@ -1,7 +1,11 @@
>  include $(src)/Makefile.libfdt
>  
>  SECTIONS := text data $(SPECIAL_DATA_SECTIONS)
> +
> +# For CONFIG_OVERLAY_DTB, libfdt functionalities will be needed during 
> runtime.
> +ifneq ($(CONFIG_OVERLAY_DTB),y)
>  OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s))
> +endif

I have to admit that I find this odd: While it may be the least intrusive
change, why do the objcopy step at all in this case?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.