[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v7 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock


  • To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 2 Jun 2023 11:21:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lbZC6dZY6YdExwDtXlp0yV00U593axmZjMsekG7IToU=; b=IWuWfutYMx5ejSvsgMZOT0DmQYw2yHJwJRWvXizSk/nRYXeHt/Tmdn8pEprFsqONOzJe0uIGZygGaouHO7+4xuTCyDpfnKa+ad/YDHtZsXmYWujF2sO5LGosaQhi4mi8cCIypEkNB2ELuyga+f9GxNyKhnbL7CWsFq9NcPshMk6IHEC/G8Ypbf793tQ+XX5LneGwh4FyYN7N+HJ3owLH0f6QNADEdXcXpDG56cn15HSuub72gECMJ7lXxSrCcMjBbOMLeBlwSfgOlToiPy6T1QtPjseI3OYMu2PlNOpuEgX/faH/uTLO21w8rvQLW8YK326zyg/fHOfUEcmOYNOp6A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5S+k0fcrC6oXWvUI1TlFMgGkb/yl4MAEjrwgp5CKLo2N7VIELx9ySFC6J2g3qwXLPCAn2FkUv4xcQ0E5YNt2/rnJhFXcCNw/HXy+zLQRPhEvN0mlkBkDc8BFh370fIdwiDWkDjajI4YQ+kxzH95OtAN4bDIPVNVJbSez3pFphv9bAksQjLIKcSFfU7z7mN0/B7b4Af/iNxOksL9Kkx7PXfuV/1arYrdErq8+0ITADAA65HX+mZNcBuqdsjQiVc3dfxTiWhLwE/uNriJyjTVALris5BWVsdXDRlWl69VsxYdH1KQsPklVjFDzJOQ2zGmMS+rsjbl/RlHhP1zagXRdg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: michal.orzel@xxxxxxx, sstabellini@xxxxxxxxxx, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 02 Jun 2023 09:22:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.06.2023 02:48, Vikram Garhwal wrote:
> @@ -189,6 +194,8 @@ int iommu_add_dt_device(struct dt_device_node *np)
>      if ( rc < 0 )
>          iommu_fwspec_free(dev);
>  
> +fail:
> +    spin_unlock(&dtdevs_lock);

Nit: Labels indented by at least on blank please (see ./CODING_STYLE).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.