[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: Add Kconfig option to require NX bit support


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 2 Jun 2023 15:02:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pTUpbQGZEwaS+dRF/F/pVs77IdqMv/fPz7OCOMRFwQU=; b=XpKC4si1zRDK6i63dYIPwcuMrWeAzPNMVUVcfsUohfVBOO2hXvHJ4hx5OposleAc0QMm4IgFTV8jK/04J/YqYJg1ngEgYbrgazo8pHMRn3j7IZPN7+ZSMtx4cQ5WAt+MClHaNFnUHVDiSjqpwI81aNQ+4wNDSiwNMqgN0qIkyvdsKMrsFE7GT+Fcq/9ZAPeINeXslkvTHqFerXSvXR+pKtUALi5mDgpELlb5gtCzGx0Va2I9V3DFwCH52nNgMpbSFHkXnQHpBPI9Q6Eky/XrOHGE7WJXSm/nwEPPo3ATnsjOb9Az72RkLcf4QILk0SZFho7ruuLdj9kEvDzXYWlOVg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9xB4z8JbzxJd5MSLVJpA7vdSNeV1qfvbYWS/NtY57qgbsCw+bwPwFXsO4hU8knrG0W8TRBmW6ihS3jr4wE7ePDG+xUdP15HoqBW+93JpEwF+ICD7IC9I8KLW1cswNFbwWz3KN4xxxlFzTao6x5SW1FFEAiH6Eklen8Uqg5gWSMEyNZZM1ND1h38NFL36rBTexqZnfIQhr4eqZzToGtRUXCqIiq4pJdbrZliVokPtUjx7WGFb8u6xlDaJFiPWSoLYZ3l73Mi9wOftSFdngndkb+JLoO5OsYgYRAIdFq+/5SpqtJCHzuxS5Uz+KsdLd+oU6aO9NY97ySSwUgXkLc0PQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 02 Jun 2023 13:03:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.06.2023 14:05, Andrew Cooper wrote:
> On 01/06/2023 6:43 pm, Alejandro Vallejo wrote:
>> @@ -151,6 +152,11 @@ not_multiboot:
>>  .Lnot_aligned:
>>          add     $sym_offs(.Lbag_alg_msg),%esi   # Error message
>>          jmp     .Lget_vtb
>> +#if IS_ENABLED(CONFIG_REQUIRE_NX_BIT)
> 
> This doesn't need to be IS_ENABLED().  #if will DTRT for a non-existent
> symbol by considering such to be 0.

And then it really should be #ifdef, not #if (like for all "real" Kconfig
symbols).

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.