[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()
- To: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
- From: Alexander Bulekov <alxndr@xxxxxx>
- Date: Mon, 5 Jun 2023 04:06:38 -0400
- Cc: Mauro Matteo Cascella <mcascell@xxxxxxxxxx>, P J P <pj.pandit@xxxxxxxxxxx>, Dmitry Fleytman <dmitry.fleytman@xxxxxxxxx>, Beniamino Galvani <b.galvani@xxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Strahinja Jankovic <strahinja.p.jankovic@xxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Alistair Francis <alistair@xxxxxxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>, Andrew Jeffery <andrew@xxxxxxxx>, Joel Stanley <joel@xxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx>, Thomas Huth <huth@xxxxxxxxxxxxx>, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, Subbaraya Sundeep <sundeep.lkml@xxxxxxxxx>, Jan Kiszka <jan.kiszka@xxxxxx>, Tyrone Ting <kfting@xxxxxxxxxxx>, Hao Wu <wuhaotsh@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, qemu-devel@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 05 Jun 2023 08:06:57 +0000
- Ironport-data: A9a23:SFuZqqKxL48aKkfpFE+RkJQlxSXFcZb7ZxGr2PjKsXjdYENSgTIGn zBNUT+DPPfbZzSmKdpxb96+90IGuJOEmoM3GgBorCE8RH908vbIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOOn9T8kjvvgqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f7nWYsWo4ow/jb8kg34qyu4GpwUmEWPpingnePzxH5M7pCfcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aue60Tqm0xK6aID76vR2nRHe545gXBYqhea7vB3S9zx54 I0lWZVd0m7FNIWV8AgWe0Aw/y2TocSqUVIISJSymZX78qHIT5fj69ttMWscDK4mwctuCFse9 dIELxMEaznW0opawJrjIgVtrsEqLc2uJYBG/385nGCfAvEhTpTOBa7N4Le03h9q3pEITauYP ZBDL2M+PXwsYDUWUrsTIJs6jOGknFH1bntVpE/9Sa8fuTiIlF0tiuGzWDbTUs6XRJ8Lkn6Yn 0/p1WPWDiAbEfma1yXQpxpAgceKx0sXQrk6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL FYbkhfCtoA3/U2vC8D+Bli2+S/V+BEbXNVUHqsx7wTlJrfo3jt1z1MsFlZpAOHKfudsLdD2/ jdlR+/UOAE=
- Ironport-hdrordr: A9a23:tGx3IaC24dKhNC3lHemT55DYdb4zR+YMi2TDtnoBLCC9F/by/f xG88516faKskdpZJhNo7G90dC7MBXhHP1OkOss1NWZMDUO41HYS72KhLGKqwEIfRefygdz78 pdmsNFZuEYY2IK7voSmzPId+rIyeP3iJyVuQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 230601 1218, Akihiko Odaki wrote:
> Recently MemReentrancyGuard was added to DeviceState to record that the
> device is engaging in I/O. The network device backend needs to update it
> when delivering a packet to a device.
>
> In preparation for such a change, add MemReentrancyGuard * as a
> parameter of qemu_new_nic().
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
Reviewed-by: Alexander Bulekov <alxndr@xxxxxx>
One minor comment below.
> ---
> include/net/net.h | 1 +
> hw/net/allwinner-sun8i-emac.c | 3 ++-
> hw/net/allwinner_emac.c | 3 ++-
> hw/net/cadence_gem.c | 3 ++-
> hw/net/dp8393x.c | 3 ++-
> hw/net/e1000.c | 3 ++-
> hw/net/e1000e.c | 2 +-
> hw/net/eepro100.c | 4 +++-
> hw/net/etraxfs_eth.c | 3 ++-
> hw/net/fsl_etsec/etsec.c | 3 ++-
> hw/net/ftgmac100.c | 3 ++-
> hw/net/i82596.c | 2 +-
> hw/net/igb.c | 2 +-
> hw/net/imx_fec.c | 2 +-
> hw/net/lan9118.c | 3 ++-
> hw/net/mcf_fec.c | 3 ++-
> hw/net/mipsnet.c | 3 ++-
> hw/net/msf2-emac.c | 3 ++-
> hw/net/mv88w8618_eth.c | 3 ++-
> hw/net/ne2000-isa.c | 3 ++-
> hw/net/ne2000-pci.c | 3 ++-
> hw/net/npcm7xx_emc.c | 3 ++-
> hw/net/opencores_eth.c | 3 ++-
> hw/net/pcnet.c | 3 ++-
> hw/net/rocker/rocker_fp.c | 4 ++--
> hw/net/rtl8139.c | 3 ++-
> hw/net/smc91c111.c | 3 ++-
> hw/net/spapr_llan.c | 3 ++-
> hw/net/stellaris_enet.c | 3 ++-
> hw/net/sungem.c | 2 +-
> hw/net/sunhme.c | 3 ++-
> hw/net/tulip.c | 3 ++-
> hw/net/virtio-net.c | 6 ++++--
> hw/net/vmxnet3.c | 2 +-
> hw/net/xen_nic.c | 4 ++--
> hw/net/xgmac.c | 3 ++-
> hw/net/xilinx_axienet.c | 3 ++-
> hw/net/xilinx_ethlite.c | 3 ++-
> hw/usb/dev-network.c | 3 ++-
> net/net.c | 1 +
> 40 files changed, 75 insertions(+), 41 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/net.h
> index 1448d00afb..a7d8deaccb 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -157,6 +157,7 @@ NICState *qemu_new_nic(NetClientInfo *info,
> NICConf *conf,
> const char *model,
> const char *name,
> + MemReentrancyGuard *reentrancy_guard,
> void *opaque);
Does it make sense to roll *reentrancy_guard into NICConf here?
|
