[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Fix incorrect taint constant
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jun 2023 11:44:51 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NL4nwbo+OLRZcDM4Qth1iN9b62Z9Qz0zTF1XjqN8ZOs=; b=U8RlrHWDqy+poyTMc2naDCMThXcbqoNbEpmIZfc1OCqld87mtqyAsnEJUGMQIBmt/X/7ny9NNwW8/nMygLbR5Jjh8jSM4fhixzupbfxs+JtfJY+uWatT5u7nHspc41dlGZJX1uHc3+NneZYvFqGRVdG+ZW1WhTdL6g0g3J1Z/viLhkmk4nqkwVS/FpFniQA0aTcfWkRNXw/+9Y6OuNFkS1qEk7+Pnr726wi7N0WObn86b+Mdu6WLjZS6yaCldVyGNFgP0l0OFveYAWymfk3QOGziRUELzCTrj6MH26ecgEdluazDGzfgkOz61t4t4NOG23PK0nSnDtk3VkkMXBlYPQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KK46w8bYqn6dfZ8JVncfqfkpQYOuSZ9M59XJ4TuDE24MET9+9a6kdprST1XuieERxdjhP0M8zadPF7N10MWondSX84rXHh+Mb8RFLTX32gGD6zffLZAhjwdN65bsgiEeP4cN6zMJgx/7aAwImnErqET7R7yukcMOqy68dxNSi1tLxAyR/2ZnSv3KL5cKGUi+66RZsu4e0rXbJjlrRZ/6m2Hslt5zmlpZ0azGHho1W8bbjdsoJYKT90qNqTHX8VK2dAX2QkAYNAvIAEXEciyb0u2Cz8ZbHC5QNno/XzvhCyWdbcxhlKebUv37x9J7HUqLdOyphSO5rsxl827LwYyQJA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 10:45:23 +0000
- Ironport-data: A9a23:iGwGEK1rFuVVqgq1WPbD5VBwkn2cJEfYwER7XKvMYLTBsI5bp2BRn DFOXWqCPviMMTH2cox2bongo0xVv5/Xz9NiQAFupC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gJmOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfEEt32 PMBdWA0MDPArLy90eiDS+81r5F2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFQZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiANNJTOLjqZaGhnWw/UsaC0BOCWekuMuep2SHdt5HM Bwtr39GQa8asRbDosPGdze1umKetxgQHf9ZCfQn6Rqlw7DRpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRuQEyUIKW4JZQcfUBAIpdLkpekbkRbnXttlVqmvgbXdAirsy jqHqCw/gbQ7jsMR0ai/u1fdjFqEpIXNTwMzzhXaWCSi9AwRTLCiY4uk+F3K98FqJYySTkSCl HUcks3Y5+cLZaxhjwSISeQJWbuvuPCMNWSEhUY1RsF5sTOw53SkYIZcpilkI1tkOdoFfjmvZ 1LPvQRW59lYO37CgbJLXr9dwv8ClcDIfekJnNiNBjaSSvCdrDO6wRw=
- Ironport-hdrordr: A9a23:tUnJaaGrQ8UpojfepLqELMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT0B9YueAcGSTW6zBkXWF+9VL+qj5zEix792uq0uE1WtRGtldBwESMHf9LmRGADNoKLAeD5 Sm6s9Ot1ObCA8qhpTSPAhiYwDbzee77a7bXQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/06/2023 11:29 am, Bertrand Marquis wrote:
> Hi Andrew,
>
>> On 5 Jun 2023, at 12:05, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>
>> Insecure the word being looked for here. Especially given the nature of the
>> sole caller, and the (correct) comment next to it.
> Good finding.
>
>> I've left the taint constant as 'U' as it's a rather more user-visible.
> I would vote to change the U in I here as it will make it more coherent
> with the doc after your added fix for it.
>
>> Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Julien Grall <julien@xxxxxxx>
>> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
>> CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>
>> I'm happy to change 'U' to 'I' if we think that no-one is going to be
>> impacted
>> by it. I just wasn't sure.
> Here i do not think many will be impacted so I would rather make this
> coherent.
Ok. I'll submit a v2 with everything adjusted.
~Andrew
|
