[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 10/10] x86emul: AVX512-FP16 testing
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 5 Jun 2023 13:43:33 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=185Qz9TKNGSasx82Cv1ifwrXG32QQ26gxGfE9bmFfNI=; b=Zv97muWSK5hSjdTdpm3LDHBOo46XxIFEKSgjiTLA52gh5YfRRydclPhg751esWrPZgyyXoTvkQVRM8JKm/qWO2OAJ6r1TVQUeFcq6VLNvJFj681Mljsbk4Mcp0vXTunXCxx2ONu9xy04a+bS0ETy8QOMVyId1wouEEcB5FfosmM/YuZDjnigGIQ4kXFzkJSKoTr4T89DNbFY5bsiXVVKTIj9IHW0o2B6ug8hkTBKvmzyldozulm1Jw9ZkBz7Osi6xdw62Omv0gHF4JQM7/j4D/UpuNuji1fAlJ/B+3PzX163O5lG5WyJwFOk/E1P/IVPtpFkSNtsU/No2spj3aDIQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sl8uC/syV/zgCzKgTN7doigIbkEsV1GFfqo3B+prEya+Vl8G0fWlmtFgB4woVVEBJZE4ZigrEw6EEfjLl5TrUhxzKu83I2xXq9KSSNtCxminWCejM3ODUNDgqGElclBRg9cguWrcusvbXIn+3v41z5F2TxCWDjo+QrcJgVNyZ9luJUelr6U7XR9ScjJmA1JGEaPEvAKoZIPMWsiDlwcl/HxM6S/8HmSyTLrxhotQXYEixhLCIomQdE7lWIMqkj7QGtUJvv7yWrrtaGyEXzF90JbPB7G1ln233CHDa0c6le9I+wh1qABLC8Kf1iXvzeG3eDReGTlk5hPFW8zoTV3BtQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 13:44:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZZj0oGedpV97oKUGQjzlrrKT8eq98kQ+AgAAIv1A=
- Thread-topic: [PATCH v2 10/10] x86emul: AVX512-FP16 testing
Hi Jan,
> -----Original Message-----
> Subject: Re: [PATCH v2 10/10] x86emul: AVX512-FP16 testing
>
> Henry,
>
> On 03.04.2023 17:00, Jan Beulich wrote:
> > Naming of some of the builtins isn't fully consistent with that of pre-
> > existing ones, so there's a need for a new BR2() wrapper macro.
> >
> > With the tests providing some proof of proper functioning of the
> > emulator code also enable use of the feature by guests, as there's no
> > other infrastructure involved in enabling this ISA extension.
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > v2: Add CHANGELOG.md entry.
>
> I notice I forgot to Cc you on this submission, with said addition.
> May I ask for your ack (or otherwise), please?
Thanks for letting me know this (and also remembering the changelog
entry)! My suggestion would be making the entry look like a complete
sentence instead of the current form.
But I also understand this is quite nitpicking so I will let you decide,
either making it more readable or keeping its current form is fine with
me, and if you want to improve the wording, you can do it on commit.
So:
Acked-by: Henry Wang <Henry.Wang@xxxxxxx> # CHANGELOG
Kind regards,
Henry
>
> Thanks, Jan
>
> > --- a/CHANGELOG.md
> > +++ b/CHANGELOG.md
> > @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog
> > - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the
> > system
> > wide impact of a guest misusing atomic instructions.
> > - xl/libxl can customize SMBIOS strings for HVM guests.
> > + - x86 AVX512-FP16
> >
> > ##
> [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-
> 4.17.0) - 2022-12-12
> >
> >[...]
|
