[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/microcode: Add missing unlock in microcode_update_helper()
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jun 2023 16:08:16 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6RzyrmXTgr17zB9hZyMxRsfjOTHV0vweo0j7Q6VzrjM=; b=l72kEtzwrj3Vdns1H5xC+LzLe3V6K5grNwHE/mldBwZMFNq4fbqHFUNW7x2mmxfH+q4C4obnQooAK+5R3NgyZDMoPxcg6xaFWdV6qCM/7CFSkAtAQZVTLdBc8ctvZMu8SFrqtX6SOZ9An5MpH5Muqq36/tKb6DCZjj6DHUCgEEYtku4J4rFgNk5WRtUq/Wo2h2o/B9go6QMdfWNVVDCISC8eH8p6qg1mjmu6RIbAoYxMGl8lHBM6i4sXsjMYT46d9UxXqQmUrX/PgvdjXr6Vwdx0KK/q3iOYxC4zDTgKx9isJy6LCfiZvMPso+Ge0iKpqmpySiZqlUHeOHNbXRT+bw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qp/0oph10Fg/OaJq7mBSwBmLBal/BANdrn8jxxcKsbT11nPJpK9GXhgfXttH0kEmHK4Tyb8uoSJoOuUtbpuzDKzdoNEKiSXbsAPuzhmaQ3lvFhj0O85bJOEMRzlRU5eolc7gDXQHCuGqL5a4u+g/dFhIgAdL5DX8jm9nRJxOUgKa2SizGK9wsS6x/5kgt2D5qBUxnVo7eaWV/gAuLo3NaUmwE9PdYfUPGvipscj201V5r+KDezhsisILJLkK/JwSVH7fZ0gLkCzLL71YO17FEe+SByGFZXGyRWEAvtY7oxlZ+oo/1dKoucTHIef99r8sKvb+ubKJLDIj34dJm7gE8w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 15:08:51 +0000
- Ironport-data: A9a23:yhXa/KA3J4/zbxVW/+jiw5YqxClBgxIJ4kV8jS/XYbTApG4j0D0Ay mJJCmqEPPyMNGOheIwjO4y0pBtV7cWDmoNgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMs8pvlDs15K6p4G1A4gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2c1FGkBE2 tckeG4TQA2Au7qHnpmec7w57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrsgA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37aTxH+iA9pOfFG+3vdp3UbPzFIcMTo1dgalv6aXjFGdBusKf iT4/QJr98De7neDR93wXRS+rGSD+AAVX95dEeoS4wWK16aS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hTG4NDURLGQCTTQZVgZD6N7myKksijrfQ9AlF7S65uAZAhn1y jGO6S0h3bMaiJdR073hpQyWxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTXKAnRNNlFP8q4DQA=
- Ironport-hdrordr: A9a23:crvHwahTjUY7hixEhZVWAT1LXHBQXuAji2hC6mlwRA09TyX+ra yTdZUguiMc7Qx7ZJhOo7690cW7IE80l6QFg7X5TI3DYOCOggLBRuxfBODZsl7d8kPFh4lg/J YlX69iCMDhSXhW5PyKhjVQyuxQpeVvJprY4dvj8w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/06/2023 4:01 pm, Alejandro Vallejo wrote:
> microcode_update_helper() may return early while holding
> cpu_add_remove_lock, hence preventing any writers from taking it again.
>
> Leave through the `put` label instead so it's properly released.
Fixes: 5ed12565aa32 ("microcode: rendezvous CPUs in NMI handler and load
ucode")
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I'll add the fixes on commit.
~Andrew
|
