[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 05/12] arm/sve: save/restore SVE context switch



Hi Luca,

On 06/06/2023 14:22, Luca Fancellu wrote:


On 1 Jun 2023, at 11:17, Bertrand Marquis <Bertrand.Marquis@xxxxxxx> wrote:

Hi Luca,

On 31 May 2023, at 09:24, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:

Save/restore context switch for SVE, allocate memory to contain
the Z0-31 registers whose length is maximum 2048 bits each and
FFR who can be maximum 256 bits, the allocated memory depends on
how many bits is the vector length for the domain and how many bits
are supported by the platform.

Save P0-15 whose length is maximum 256 bits each, in this case the
memory used is from the fpregs field in struct vfp_state,
because V0-31 are part of Z0-31 and this space would have been
unused for SVE domain otherwise.

Create zcr_el{1,2} fields in arch_vcpu, initialise zcr_el2 on vcpu
creation given the requested vector length and restore it on
context switch, save/restore ZCR_EL1 value as well.

List import macros from Linux in README.LinuxPrimitives.

Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

---
Changes from v7:
- Fixed comments for sve_context_init and sve_context_free,
  protect arch.vfp.sve_zreg_ctx_end, arch.zcr_el1, arch.zcr_el2
  with ifdefs. (Julien)
- Given the changes, dropped Bertrand's R-by

Hi Julien,

Are you ok with the changes I’ve done? Are they addressing your last comments?
Sorry I was away last week. I will have a another look in a bit and commit if everything is in order.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.