[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v7 04/19] common/device_tree: change __unflatten_device_tree() type


  • To: Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • Date: Tue, 6 Jun 2023 12:09:35 -0700
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QRCCUnj7US0D9q0dJGoxlMNei8MnZGvl67+RcMEadJA=; b=gIZWQZBOs/w/LC0h5GCroiBMoDq7bCTAzmqWPIXfLilVNCJRn5D9ilzBazfr/Ys1GmFokzaHQGxD58LD7bHFrtjhnJnB5+7VKt/RSlOpoen8CNIPz5e6QRQUfujcLRxnocZ21xj9dvFwwnMdJ+BLe7qgsSdY0e984SvGeefCgG/hpxGtpUEdFZswi3tEhgf5YgikTKkF11U+vBIVuhFdk604dq2wR3xWwr86nJxYF6x65QXUDDpOQDW1704H4wwXnydPDWzp8ekhkuovoA3EUb2F/x+8mFAwDfQjDN7vkNS7BtOZE4kgJem2UjMRjC3P9ffL2ScHpMzY9B+GOZxVbQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmyFKrqckVjAetdczLC02ZC5lBek5/9BhGfF6m10DgTdytRYMtSvAuMVbDdFflWAZbyFhvX7hgAM1YWoo510ra1U+5jNcgG0+OnBuBLZ6k28cCqr417odulyWByYpNIF0jGuBefLvquJZjZr1Dnyzlh86QJaG3D+f5t9W8rDOmV80kjvXmrJ2VM8lHv9GWWLXF+Fj6OMbh87KKoFDVd270S00alKJYgx9o0QKv0hiubKwij5B3RuSslYuV2rVlx2uzTzhv8ikq1sSKdCBOhrLfnKf/om3v435nivCNA6TayrIu2kQEPa8JrPsUuMcDIYZ0A8Y6on1WQkBMAmUvwMhg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: michal.orzel@xxxxxxx, sstabellini@xxxxxxxxxx, jbeulich@xxxxxxxx
  • Delivery-date: Tue, 06 Jun 2023 19:09:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Julien,
Will update the commit message regarding why we need to export this for dtbo programming.

On 6/5/23 12:04 PM, Julien Grall wrote:
Hi,

Title:

'type' is a bit confusing here. How about "Export __unflatten_device_tre()"?

On 02/06/2023 01:48, Vikram Garhwal wrote:
Following changes are done to __unflatten_device_tree():
     1. __unflatten_device_tree() is renamed to unflatten_device_tree().
     2. Remove __init and static function type.

As there is no external caller yet, please explain why you want to export the function.

Cheers,


Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
---
  xen/common/device_tree.c      | 9 ++++-----
  xen/include/xen/device_tree.h | 5 +++++
  2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index bbdab07596..16b4b4e946 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -2083,7 +2083,7 @@ static unsigned long unflatten_dt_node(const void *fdt,
  }
    /**
- * __unflatten_device_tree - create tree of device_nodes from flat blob
+ * unflatten_device_tree - create tree of device_nodes from flat blob
   *
   * unflattens a device-tree, creating the
   * tree of struct device_node. It also fills the "name" and "type"
@@ -2092,8 +2092,7 @@ static unsigned long unflatten_dt_node(const void *fdt,
   * @fdt: The fdt to expand
   * @mynodes: The device_node tree created by the call
   */
-static int __init __unflatten_device_tree(const void *fdt,
-                                          struct dt_device_node **mynodes) +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes)
  {
      unsigned long start, mem, size;
      struct dt_device_node **allnextp = mynodes;
@@ -2230,10 +2229,10 @@ dt_find_interrupt_controller(const struct dt_device_match *matches)
    void __init dt_unflatten_host_device_tree(void)
  {
-    int error = __unflatten_device_tree(device_tree_flattened, &dt_host);
+    int error = unflatten_device_tree(device_tree_flattened, &dt_host);
        if ( error )
-        panic("__unflatten_device_tree failed with error %d\n", error);
+        panic("unflatten_device_tree failed with error %d\n", error);
        dt_alias_scan();

This function doesn't seem to be called in the case of the overlay device-tree. Does this mean that it will never contain any alias?

  }
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index c2eada7489..2c35c0d391 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -178,6 +178,11 @@ int device_tree_for_each_node(const void *fdt, int node,
   */
  void dt_unflatten_host_device_tree(void);
  +/**
+ * unflatten any device tree.

Most of the exported function in device_tre.h have documentation. Can you do the same here?

+ */
+int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes);

NIT: From an external interface perspective, do we actually need to pass an extra pointer? Can't we instead, return the pointer?

+
  /**
   * IRQ translation callback
   * TODO: For the moment we assume that we only have ONE

Cheers,





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.