[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v7 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller
- To: Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Tue, 6 Jun 2023 13:33:36 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/6+p8zqO5QnQqWj79oCRJlUkmOshIvTqZgbo1ZyT3XQ=; b=UDCoauNnxdrNW22Z3Jur5W83a8aCe66COHNXUaj1vhpXMVtL6JgjgqVsl7DhFgmTRI92irxDmJRNxrxtW9wAAOVAbZ5jXL37TYwV12cstEY8K3AYUbwy0BdN5d70vUHf4WYdiqtyArOUovjDpnKIU40hBZMCv9KtNN1XRimGozU282ZCBpyLIE0zRhCgCr3zplkSgpRSd3fTry3HPQCfAxb4LPmHr01wVbgPe7/xrABQT5kfILqAavDBN5q0OoP+qVYdIAAU0Z3xcns95EPWZGs5a/lzSxXvz13KMcR1GmbhVhApKCCMrbhaX5QdMVAyIm/jS9s/vubUogCx2/2KAw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBs6eQ9npMemXf9nxgz5nIMThxdQNdNjE1L2nhZssx1QzJoIutc8zFs3gcjQ/AJSQhkQfF5x0NeIfrstWWqPR3cHG3LezXpN9DhOQErNwYYLlEmHpKXJrmXWVmv6/ktpP9z8GdMRqPq4pZo49ARGHnf5cP18lwchk/ZlQmWC1shou5kUiWhCHS+Ly6Wm87unJuRzyt3ueHeBYBvyi3bLoREvww1h1e2CgadzPm7zA37i2Q3U4XolLmW2CxF/Qc90Ri/FCk4gNkrB0RwHx9nMI4hn5CpZJps8qrNuMDtjbhbVkYCC0N75UEkpWEOTkK6KiZarGMYAq26t0dQFVT1USA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: sstabellini@xxxxxxxxxx, jbeulich@xxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 06 Jun 2023 20:33:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 6/5/23 12:22 PM, Julien Grall wrote:
Hi,
On 02/06/2023 08:45, Michal Orzel wrote:
On 02/06/2023 02:48, Vikram Garhwal wrote:
diff --git a/xen/include/xen/iommu-private.h
b/xen/include/xen/iommu-private.h
new file mode 100644
index 0000000000..5615decaff
--- /dev/null
+++ b/xen/include/xen/iommu-private.h
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+ /*
incorrect indentation (<< 1)
+ * xen/iommu-private.h
+ *
+ *
+ * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights
Reserved.
+ * Written by Vikram Garhwal <vikram.garhwal@xxxxxxx>
I'm not sure if placing the copyright is appropriate, given a single
prototype for a function
not really implemented by you with just spinlocks removed. But I
might be wrong.
I agree. If you want to add a copyright then it should be the one from
the original author.
But in this case, I don't think we should add an copyright as there is
nothing really interesting in the header.
Thanks for pointing this out and explaining the process. Will remove in
next version.
Cheers,
|
