[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 7 Jun 2023 08:30:18 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qRnWqtyjSOfTIuj0u2e9fajLhII/WBb8MtvnsrmMI64=; b=hNsH0oOP08Gu1oid4+RUxyFgiDfPkctyyNVnXG2S+1cztSI16UCrIIufM/qiZRL1LqrtpYnW0T/cMflWeMYMm9R6LS/Z4nKd37s6QuEFE0fFESq9KdY4iI/Sv3MR9Hd1Mz8rTyUlYUVM8c/d3oOGKIg/XVT87546xpZRCv3zthdpG0xzXOLnlZl8mByfyBGmSKA4Fpc8bUhG9fPe0J+3cLYxwWh7ZIScyQeGY/dM54ntM4Rk3ipp8zUMpSqAh3XhlZyCQ3t9f4lY18oNbjhNjSJrtGivLinEOB9kehmL80xlhZa41XjzeEJ7insUNSFA4++zjE49+06KwI+n2z0OjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0PyH02yxrtAs4OAADfw8oWNmu03/kscVLBfps89YB+rnvz7NJz7/6gQD564RWKhaaHMnPUJ0gyoX0kUEmHwfX8HOIyIQRXYQrALeEvz1mi4YINKnZGvQcCiK/V7NwC19Jw7+GNYLmY1mZsxpmy5vbPD7zpTTZKkmuVS0JpeFUpmU/7+W8s8s8it8Lm0epF0A59hh1QsGS7f9sXoI0y9UBr+gZ4nEUI2KRuY0I3tOYOFca7riEF+ppUeVQyUsNJfWw1igczWLZ9ncm1fxdtBgEOKtLpxBHycwA8kOddzeNf2xcnE98DaoTwRWlAfFbTyTjqkjoMZLnFk/CpWMED3vg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Wed, 07 Jun 2023 08:30:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZmLWi8+vNVoAZ4kq/761cbXnoFa9/AxyA
- Thread-topic: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree
> On 6 Jun 2023, at 21:29, Vikram Garhwal <vikram.garhwal@xxxxxxx> wrote:
>
> Hi,
>
> On 6/5/23 12:12 PM, Julien Grall wrote:
>> Hi,
>>
>> On 02/06/2023 01:48, Vikram Garhwal wrote:
>>> Add device_tree_find_node_by_path() to find a matching node with path for a
>>
>> AFAICT, the only difference in name between the new function and the
>> existing one is "device_tree" vs "dt". The latter is just a shorthand of
>> "device tree", so it feels to me the name are a bit too similar.
>>
>> From my understanding, the main difference between the two functions are
>> that the current one is starting from root whereas the current one is
>> starting from a given node. So how about "dt_find_node_by_path_from()"?
> Thank you for the suggestion. This name was added in v3 as Luca Fancellu
> suggested to rename this function to "device_tree_find_node_by_path". I am
> okay with renaming it to dt_find_node_by_path_from().
>
> Luca, Michal and Henry: Does the dt_find_node_by_path_from() name works for
> you?
Sure, go for it!
Cheers,
Luca
|
