[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jun 2023 15:41:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vZtgqitJeU1NED135HtzzAhU8zoe9Ra9zb/jcn6PWSY=; b=b+nqBErRNRGafOsdauUVI+oMBIF7lAA7KamzkIA+p8+XIja3iX9JhZAPE0efpG5OhEbjLKIBfKM2txfTOr5pviiJdtJ1N2goHCaonvkSbdkirVZHjtv/PDFz7LVLrMDFfXvidC5YK23vSpTHyRpFHXMtTIMVLty2J/QnIqYbi9YzSbhLhl0HuPm2rbhjhaII4QjmOk//NBeRAWeEeg1wReiO3PBFkCo8JSijf3e5URK91+zOJ2xj/UMIrMJR0j8LBpWAoVP5KA6c/POW1//00/IQaO0cr3Uf/zt53qZ5wN2YKkw+lUyHzEiY1fIR0Zmbh3TYDPjO8faU04pep5FOPw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=by5nRT545AJSWkSL9EraCx5i5aSDsfLfd7zQJSwNFGbc3NEqPF88iEK1klBtzoJoF0bh+qWT5G0oHujntEA2b8rK8A2idPM07QA1i/32mp1dpyE7JnJoSNcEi+LX4mCearxeDUH216TdVCfSzm5VdqHZDrSB5Y7pVPy+30Or8W2Zx+Vy2bDpIlklRMGYsWIn08/5TdbX31uEJGAZGu70BfSFLRnzU9SWdMktxoQ96pI5BX9AqwHAR1ho9I13eAsel/I8XnFxQ7O60o+fAb6waH3MHa9ZxlvOQBViMaMZ1j9VdRJnnef6165EMk8T2gEMkFAQf6yDZlsCbW1sLfrbKQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 13:42:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.06.2023 14:45, Stewart Hildebrand wrote:
> On 6/7/23 03:59, Jan Beulich wrote:
>> On 07.06.2023 05:02, Stewart Hildebrand wrote:
>>> --- a/xen/include/xen/iommu.h
>>> +++ b/xen/include/xen/iommu.h
>>> @@ -26,6 +26,9 @@
>>> #include <xen/spinlock.h>
>>> #include <public/domctl.h>
>>> #include <public/hvm/ioreq.h>
>>> +#ifdef CONFIG_ACPI
>>> +#include <asm/acpi.h>
>>> +#endif
>>
>> This header is supposed to be usable without #ifdef, and then ...
>
> You suggested adding the #ifdef
>
> https://lists.xenproject.org/archives/html/xen-devel/2023-05/msg01409.html
>
> Please clarify
Hmm, indeed. Which is a sign that neither solution is really nice. I
guess the one with #ifdef is slightly preferable because it'll avoid
(as said in the earlier reply you refer to above) the need for every
arch, even if ignorant of ACPI altogether, needing to have an
asm/acpi.h. I guess we really need to deal with all of this better
in / by having suitable common code.
Jan
|
