[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/hvm: print valid CR4 bits in case of error
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 8 Jun 2023 11:01:19 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nb5CaHjwk290S4szU/qdBjkdwOER9ldcL9C9acbk4L4=; b=VaS/j3QfNSVEg2MqAFNrWgh9pd7kK6y407kkbsFtb8bWZAjAy2T1I+XNuvpfQ6/QsRuNWrnyOLNrT03WenF57YfEHCyQLjSiMqmY+Qz2p7c6iaWiZoddzcMrxVDy9/V4vxKIOxkgJaJ9yhrd2g11G7ysIESe9iXBCMs55/HgHrXj/m5jbIhsx7BQLQfEyEtTCcjpxCtgBvWo3o4da2MKhM6AitpuW+zbtAn+l/9D5sEfDpo5u5YP7YDVE2Y/GXR7yEUeLSBSDrGSH2eVXBPmRIriuNt7R6HIKEw0tQES+7vG7PTP2YTVvLh3oK5nSzmRPiKNpyO1IzOTpY/DDyjj8w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyG0QCJdFsrtdcC2L5vPysfRBf/TwbLcj8FbZMzNlSYdAkIE1qVV7569OivRAn7kmXK1YIYZi0t/A4kctIklQWS2KAvVssuxm3lkppEcaoGq4yESEsG/xh9zTsZLu8YZlqilsZU6NIpuj1hnjiE4IMDoP4C32WF+/zYiby9Ja+GoZ85Q3aHb2d9aUw4SuPia5rMs4If2QvC99HzbOi+zeY9ypPmzxbhnhhSb7kpGAxdxZSRBb2MxG5Xz1Vg+IVi4Ra955Vb3fLmcK1yurjlwr5G39cmiJXzipP6QWfuMaYXGbX5uoMM52cGQ7t7HYk+A4Abh9yZU0oQEkqg2Xv+UVg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 08 Jun 2023 10:01:46 +0000
- Ironport-data: A9a23:6gTjCqx3OCRZ9DP21dZ6t+cVxyrEfRIJ4+MujC+fZmUNrF6WrkVRx moYDWGGb/uNYTSgLthzbIXk/EgOscfSz9JmTwZkpCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EsHUMja4mtC5QRgPaAT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWETq d4aMhMsUjnZvduk2ZDlRstRnO12eaEHPKtH0p1h5RfwKK98BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvTaVkFAZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiAN1DTuDlp5aGhnWI2VAvFgM2d2eAsOWH10qYWPYcK ksbr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOtsU7WDgr3 V+hhM7yCHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A5sa5pog210jLVow7TPLzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q==
- Ironport-hdrordr: A9a23:d4Kk+aFFF+sewpwBpLqE7ceALOsnbusQ8zAXPiFKOHpom6mj/P xG885rsSMc5AxwZJhCo6HmBEDjex7hHPdOiOF6AV7FZniEhILCFvAG0WKN+UyDJ8TIzIJgPH ZbEpSXWbXLY2ST067BjzWFLw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/06/2023 10:59 am, Roger Pau Monne wrote:
> Some of the current users of hvm_cr4_guest_valid_bits() don't print
> the valid mask in case of error, and thus the resulting error messages
> are not as helpful as they could be.
>
> Amend callers to always print the value of hvm_cr4_guest_valid_bits()
> together with the rejected bits in the checked value. Also take the
> opportunity and adjust all the users to use the same print formatter.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
