[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries


  • To: Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 9 Jun 2023 10:54:05 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C+L6op5DniXeSCfEV6FchGf1Lj7dsQg4xJd1GuHKi5g=; b=nacEl5bxVVTx8P+MQHfocfmjWj4HD5V/QIw6ymOj0BTg/ndjQN6cyaQDEISuqxkCPpJQiY9BlVr1wCVy2TFQpyr+52+98BWsFrBvZalyn/4q7nXsnJRPXP0HYBmhrGIE60J+ikMuIWUBW+6/bYJXTvp0/hjC+9L9BSwzhpmHZowaYzQPGhkPJduZ/YDfJ5WKfE2V/63JNYO2F8aJhhkOT78EHYoDYgZx3RP1QSQ6wgZbfGLaeaRQc7dCoh9dyHKARcKCTz03xBP61GgX03uO74UBNT0f1gkp8A5WMRzqcc7DhlxargZMJnjj/9UvIRUYXh2selYMqBSQkvkMgA5mqw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UfLLk2KDjlG6ISaY3pZBF6DRu08EvO0EveXthFX1Llf7fDjVgTgvd030b5kKYigs9QJ3Zkg8/6y6kxbeQe8dEODfArSRaChHuikMtpFs/bS/4xNPj29eMgx8RyW3m7bI5eI7jq0X1rfQpTT9hL19urj1V96seNwS7a3C2iZWRvUULSPYlCvSuAdr+a9a9Waeu2P7+9BlNXU+kYSzCxitfeQsqXrEI0i7R0e0ps32Fiwq0/ZsK7NLbuNqNOUGkGQUSmuAJs3kzr2xGz38U+sBY78BOshIrBfCRHp6IZ1PFZxfHEt26YvVHP+rL0MWc+vrt0MvdsAuMShs7glbaQP4Rg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: tpearson@xxxxxxxxxxxxxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Shawn Anastasio <shawnanastasio@xxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Shawn Anastasio <shawn@xxxxxxxxxx>
  • Delivery-date: Fri, 09 Jun 2023 09:54:40 +0000
  • Ironport-data: A9a23:vEoJaKwVdVwxnMcn1396t+eaxyrEfRIJ4+MujC+fZmUNrF6WrkUBy WIeW26APPeKMGbzL9p1aYqw8xtT65WBn9I3Hgc4riAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EsHUMja4mtC5QRgPaAT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWdv9 uwhLBQxVxuKl8G38ZDgT7dSrMt2eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQruFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAd5NTOLgpqACbFu7n0wVCzlVU1WAmN6FmmyZZcNSA Gk49X97xUQ13AnxJjXnZDW6vXqFsxg0S9dWVeog52mlyKDZ/gKYDWgsVSNaZZots8pebSAy2 1aThNTvLSZmqKGSU3+b+baSoD6oOC4aa2QFYEcsVhAZ6tPupIUyiBPnTdt5FqOxyNrvFlnY3 DSivCU4wbIJgqYjzKWy4lbOhTu3upHSTwkd/AzPQmW/4wV2ZYioapap71ed5vFFRK6JQ1/Es HUalsy26OEVEYrLhCGLWP8KHryi+7CCKjK0qUVvFoYn3z2r8mW/dJsW4TYWGatyGsMNeDusb EqNvwpUvcdXJCHzNfUxZJ+tAcM3y6SmDc7iSv3fcttJZN52aROD+yZtI0WX2ggBjXQRrE32A r/DGe7EMJrQIfgPIOaeLwvF7YIW+w==
  • Ironport-hdrordr: A9a23:nMoL0KiOR3Nqdr/vf/LVI6wGYnBQX8d23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewKkyXcH2/h3AV7EZniahILIFvAZ0WKG+VHd8kLFh41gPM tbAs1D4ZjLfCNHZKXBkXeF+rQboOVvmZrA7Ym+854ud3ATV0gJ1XYHNu/xKDwTeOApP+teKH PR3Lskm9L2Ek5nEvhTS0N1F9Qq4Lbw5eDbSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK7aY+/X PDmwnZ4Lzml/2g0BfT20La8pwTwbLau5d+Lf3JrvJQBiTniw6uaogkc7qevAotqOXqxEc2nM LKqxIAOd02z3/KZGm6rTbkxgGl+jcz7H3Jz0OenBLY0IHEbQN/L/AEqZNScxPf5UZllNZg0J hT12bck5ZMFxvPkAn0+tCNDnhR5wCJiEtntdRWo21UUIMYZrMUhYsD/HlNGJNFOC7h8ogoHM RnEcmZzvdLdlGxaWzfowBUsZeRd0V2Oi3DblkJu8ST3TQTtHdlz3EAzMhapXsE/IJVcegy28 30doBT0J1eRM4faqxwQM0bR9GsN2DLSRXQdEqPPFXODsg8SjLwgq+yxI9wyPCheZQOwpd3so /GSklkuWk7fF+rIdGS3adM7gvGTAyGLHXQI/llltpEU4DHNf/W2XXpciFrryLgmYRQPiTjYY fxBHoMaMWTalcHGu5yrnnDstdpWD8jufYuy6UGsmK107P2w7LRx5zmmdboVczQ+GUfKyrCK0 pGegTPD+N9yW3uckPEoXHqKgbQkwrEjN1NLJQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 09/06/2023 10:46 am, Julien Grall wrote:
> On 09/06/2023 10:43, Andrew Cooper wrote:
>> On 09/06/2023 10:38 am, Jan Beulich wrote:
>>> On 09.06.2023 11:29, Andrew Cooper wrote:
>>>> On 09/06/2023 10:22 am, Jan Beulich wrote:
>>>>>> --- /dev/null
>>>>>> +++ b/xen/arch/ppc/boot_of.c
>>>>>> @@ -0,0 +1,122 @@
>>>>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */
>>>>> By default we mean to use ...
>>>>>
>>>>>> --- /dev/null
>>>>>> +++ b/xen/arch/ppc/early_printk.c
>>>>>> @@ -0,0 +1,36 @@
>>>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>>> ... the more modern form of this (GPL-2.0-only). Anything
>>>>> deviating from
>>>>> that may want justifying in the description.
>>>> GPL-2.0-or-later is fine.
>>> Hmm, I was merely following
>>> https://lists.xen.org/archives/html/xen-devel/2023-06/msg00415.html.
>>> The text at the top of ./COPYING looks to suggest -only, and I'm
>>> unaware of any other place where our default is actually written down.
>>
>> The license is chosen by the submitter/copyright holder, based on their
>> preferences/wishes.
>>
>> It's fine for Xen to say "if you've got no vested interest, we recommend
>> GPL-2.0-only", but that is strictly a recommendation and no more.
>>
>> If the submitter chooses GPL-2.0-or-later, that is their prerogative.
>> We have plenty of GPL-2.0-or-later code in Xen.
>
> From my past experience, the submitters tend to just copy the license
> from an existing file in Xen rather than explicitly choosing it. So I
> think it is fair to ask the question because our original and default
> license is GPLv2 nor GPLv2+.

Did you read the bit in the cover letter about part of this code being
derived from the out-of-tree port years ago?

You're blindly assuming that there is even a choice of license available
to be used.

The submitter chooses the license to use.  You can request that they
justify it, but you cannot demand that they change it.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.