[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] vsscanf(): Integer overflow is a conversion failure



Hi Demi,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on lee-mfd/for-mfd-next xen-tip/linux-next linus/master 
lee-mfd/for-mfd-fixes v6.4-rc5 next-20230609]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Demi-Marie-Obenour/vsscanf-Integer-overflow-is-a-conversion-failure/20230611-010926
base:   git://linuxtv.org/media_tree.git master
patch link:    
https://lore.kernel.org/r/20230610170743.2510-2-demi%40invisiblethingslab.com
patch subject: [PATCH v2 1/3] vsscanf(): Integer overflow is a conversion 
failure
config: arc-randconfig-r033-20230611 
(https://download.01.org/0day-ci/archive/20230611/202306110319.q5StyX6B-lkp@xxxxxxxxx/config)
compiler: arceb-elf-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add media-tree git://linuxtv.org/media_tree.git
        git fetch media-tree master
        git checkout media-tree/master
        b4 shazam 
https://lore.kernel.org/r/20230610170743.2510-2-demi@xxxxxxxxxxxxxxxxxxxxxx
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross 
W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross 
W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202306110319.q5StyX6B-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   lib/vsprintf.c: In function 'simple_strtoll':
>> lib/vsprintf.c:163:16: error: too few arguments to function 'simple_strntoll'
     163 |         return simple_strntoll(cp, INT_MAX, endp, base);
         |                ^~~~~~~~~~~~~~~
   lib/vsprintf.c:134:18: note: declared here
     134 | static long long simple_strntoll(const char *cp, size_t max_chars, 
char **endp,
         |                  ^~~~~~~~~~~~~~~
   lib/vsprintf.c: In function 'va_format':
   lib/vsprintf.c:1687:9: warning: function 'va_format' might be a candidate 
for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    1687 |         buf += vsnprintf(buf, end > buf ? end - buf : 0, 
va_fmt->fmt, va);
         |         ^~~
   lib/vsprintf.c: In function 'simple_strtoll':
   lib/vsprintf.c:164:1: error: control reaches end of non-void function 
[-Werror=return-type]
     164 | }
         | ^
   cc1: some warnings being treated as errors


vim +/simple_strntoll +163 lib/vsprintf.c

900fdc4573766d Richard Fitzgerald 2021-05-14  152  
^1da177e4c3f41 Linus Torvalds     2005-04-16  153  /**
^1da177e4c3f41 Linus Torvalds     2005-04-16  154   * simple_strtoll - convert 
a string to a signed long long
^1da177e4c3f41 Linus Torvalds     2005-04-16  155   * @cp: The start of the 
string
^1da177e4c3f41 Linus Torvalds     2005-04-16  156   * @endp: A pointer to the 
end of the parsed string will be placed here
^1da177e4c3f41 Linus Torvalds     2005-04-16  157   * @base: The number base to 
use
462e471107624f Eldad Zack         2012-12-17  158   *
e8cc2b97ca5aa1 Andy Shevchenko    2020-02-21  159   * This function has 
caveats. Please use kstrtoll instead.
^1da177e4c3f41 Linus Torvalds     2005-04-16  160   */
^1da177e4c3f41 Linus Torvalds     2005-04-16  161  long long 
simple_strtoll(const char *cp, char **endp, unsigned int base)
^1da177e4c3f41 Linus Torvalds     2005-04-16  162  {
900fdc4573766d Richard Fitzgerald 2021-05-14 @163       return 
simple_strntoll(cp, INT_MAX, endp, base);
^1da177e4c3f41 Linus Torvalds     2005-04-16  164  }
98d5ce0d004466 Hans Verkuil       2010-04-23  165  
EXPORT_SYMBOL(simple_strtoll);
^1da177e4c3f41 Linus Torvalds     2005-04-16  166  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.