[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] x86/realmode: Make stack lock work in trampoline_compat()
- To: David Laight <David.Laight@xxxxxxxxxx>, Yunhong Jiang <yunhong.jiang@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- From: 'Andrew Cooper' <andrew.cooper3@xxxxxxxxxx>
- Date: Sat, 10 Jun 2023 23:51:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FqlR9MC0+JwBTU3LYaBKWlf2cmR8jSePKt3Vavd4kWE=; b=kAUTqLQiiiKf42eh/zj9XBGROLjPRLLisoN4K7BBHZdOeUMLNoFmdbesPAil5MXAgXhPrAIq2L7HV+x+dzJrWI9WWtPifIUYTghRZfICJxD31H0OUv2c8fAlosrc9DSQCNPUxktbOzsCkdu9/lPZ105cSzvC/vmSQOL3HVhG5L598/TIM+hPYKTOV2NtUFldPrXAa9g3WvsXqjKB1lA3ElRaTjcqQ8DIHhjQkKp0ZVmqd6QrpKYEK9EOOReETD/f/8MuDz0skZSPsCvnTnHz7hC2R8MXGrRCvnG+URphZG63T5yNOS+uFhieADzUyQQDcq7FmYQk/K8nXZy+nDqtOA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQ7pABnP7PnnvnWBc4GJOw/4vmA4cqqfThlF/oe0ZCySzeEHm75t1gVotvU556ku3KEic3nn5NyTSW0p/LeVrYOVfdYkVbiUok7/MC58deUI9ikugca+ePBRNm6r6qD1gufW3gEjrQCLOJ3uXeWnC0YfP1t2mSbX+qF7PWBBg3iX3T3KQx0zI0C6MgU3T9Yb/+PsAlXvY9N1c+/KR1pJcSgY0ZlsZkdQBGBuxYT3Gp2H609vCcNqmzSg6Nkn6gJIRKr+IGq/jkP4oTrD32QAYGqFyN0QypXHQOhuDOqCusbpzGDHfXXaBg1ZGtX6BkOTFP/u+zEY00pOFwIqDq8gMw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, Arjan van de Veen <arjan@xxxxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Paul McKenney <paulmck@xxxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>, Paul Menzel <pmenzel@xxxxxxxxxxxxx>, "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>, Piotr Gorski <lucjan.lucjanov@xxxxxxxxx>, Usama Arif <usama.arif@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, "linux-csky@xxxxxxxxxxxxxxx" <linux-csky@xxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "linux-mips@xxxxxxxxxxxxxxx" <linux-mips@xxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, "linux-parisc@xxxxxxxxxxxxxxx" <linux-parisc@xxxxxxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, "linux-riscv@xxxxxxxxxxxxxxxxxxx" <linux-riscv@xxxxxxxxxxxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Sabin Rapan <sabrapan@xxxxxxxxxx>, "Michael Kelley (LINUX)" <mikelley@xxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
- Delivery-date: Sat, 10 Jun 2023 22:52:07 +0000
- Ironport-data: A9a23:q2g226nBqBNhBicd52fXZjXo5gwwIERdPkR7XQ2eYbSJt1+Wr1Gzt xIYXT2HPq6DY2OkKdlzOd6w/UtU7MKEz95kGgo+rCE0EiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5KyaVA8w5ARkPqgV5QeGyxH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f86dm8rLSybvrK/mO6EaMA2rcZkcda+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieeyWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTeHoqqI33QL7Kmo7NzoaeXqgkeWFlFf5UvlYD FM2xw8yhP1nnKCsZpynN/Gim1aotwAdV5x0Guw16B2lw6HJ5w+TQGMDS1ZpYcYguOc/Xzom3 BmFkrvBAT1pra3QQGiYs7SZtzW/PQARLHQefmkFSwUf6tXuqY11iQjAJv5oGbK8itzzXzT52 TGMpTMWjq8Wy8UM0s2T4lHDhxqvq4LPQwpz4R/YNkqq8wRjaYiNZIGy71Xfq/FaI+6xSliHo WhBkNOd/cgQApyX0i+AWuMAGPeu/fntGCHHi1lgEp8t3z2p436qO45K6Td9KUEvPstsUTvoZ lLDkQpL4ZtSOma6K6htbMSsCKwCyanmCMSgU/HMdfJQbZVrMgyK5idjYQiXxW+FuEQhlaUyI 7+UdNbqAXtyIaBmyiemAv8Uy74wzQggym7JA5P21RKq1fyZfnH9Ya8MLV/Icek96biArRT96 NdRNtWHjR5YVYXWeiDT9IMJBVwDJ3I2AYywoMtSHsaHIwx7CCQ7CuTa35slepd5hOJUkOnS9 32wU0Mez0Dw7VXCIB+JLGp+dLfmW5pXpGg+eycrOD6AwHEpe4+35aE3fp4+b74hsudkyJZcb fAAdt7GKPNTVjPC/zkMRZn0qpdvcgyinx6IMjC+YDknOZVnQmTh6tLiOwfi6iQKJi62rtcl5 a2t0BvBRpgOTBgkC9zZANqlyEmwpj4ag/5oWFXTIch7f1/l+4xnbSf2i5cfIc4WLg7Y7iCHz AvQChAdzcHcvok199/Gw6KFpoGmO+9/GFdKWWjd8buycyLd+wKL3YBEQM6MfDbASHnz/qSyI +lYp9n/MecGmFJiqIphD7tuyrx44dLqqtdyygViAWWObFmxDL5kCmeJ0NMJtaBXwLJd/wysV Sqn6okEEbaEIsXoFBgWPgVNRuic0O5OsjjU4+48LEjz6Glw5rXveU9IMBSWkzB1I758MYdjy uAk0OYf8Q62jDIuM9CbnmZV8XiBKjoLVKBPnokQB4n5iwwq4ktPbZzVFmn955TnQ81FL00vK Ty8h6fYgblYgE3YfBIbCXjK2ONGw5ADvhxDx1wTD12MlpzOgfpf9AZc+DI1RSxayRJI1+81M W9uX2VyIaiN5D5uiNJrWWmwEgVMAh6evEr4zlZhvHXcQk+6W2jlKWo5NuuLukUB/CRQc1Bz8 6mZw23iVTfCfc742io7H0VirpTLScF69ATE3sS6FMaMGZ4kSTXgi66qI2EPrnPPHNg4gUSBr PNr8s56eLH2OScWqKB9AI6fvZwVSROJIGhPUNlk/agTGnrbdi300j+LQ2i9c91AYfzD91S1D eRqJ8RSR1K/0jqDqnYQAqtkHlNvtPsg5d5HcLW7I2cD6uGbtmAw782W8TXijmg2Rdkoidw6N o7aazOFFCqXmGdQnGjO6sJDPwJUfOU5WeE158jtmM1hKn7JmLgEnZ0auldsg0ioDQ==
- Ironport-hdrordr: A9a23:grn/zqqaF28t+qIox6iaz4oaV5o6eYIsimQD101hICG9E/b0qy nKpp9w6faaslYssQ4b6LK90cW7Lk80lqQY3WByB8bAYOCOggLBEGgI1+rfKlPbdREW/9QtsJ tdTw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/06/2023 8:50 pm, David Laight wrote:
> From: Andrew Cooper
>> Sent: 09 June 2023 00:58
>>
> ...
>> The important point is the l suffix on btsl, which forces it to be long
>> (32bit) irrespective of the default operand size.
> Does that matter at all?
Yes, or I wouldn't have wasted everyone's time saying otherwise.
I recommend educating yourself with the instruction manual, rather than
presenting a set of statements which are all wrong.
~Andrew
|
