[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/8] xen/riscv: add .sbss section to .bss
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Jun 2023 09:04:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=taU23e3HG2GZ/V07XpCyk8o/l7WkBwv/6UKpugjEwvY=; b=lSctC1mUdFBpEuumOQ3LHEfqAEFPp5xD9/nnWH4Dv1eCXUBMKt5omoSb8Z3vFf8AoqJ0C/dmKBggwYpWO0/1jpJs61/9FtYysx5tIcqJ6bHjNH3Jm8HyEuZfUmX06n6vmioTyh/e0/zGF+Hy77B+QDSBueUVx8Kw/9/2w2CnzzJy26MwEmFtupSHSWtp4VydCPLku5CAo0CvqmKMWRgvPgsp6HH+NgNIt9LkvoWsovBbA25lT08zkttyUlxkrKpBqMD4zRRTM5fyvygA7Iidg0gKGS6mulaaz/7/hlIKJ+T5/A4efpD7ihNm7Buvchae9ZidH34P4zTRVhWgHIcD7Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jY1aoixTYqnP50UkExUVG9GImH/WNSmQelcrTEO5gefmBu9MvkYQ3oLIsQzKwREt1d8GTNMOpnaHl9aFkl0KLSwvibT4wGvGwt7kZkO5UlfIcFcQBeOoPMdHx0gltOE5zkH53O511EBddN4gNvJN/UQJ5ic5bUXJjph5dgffJceKOrL9judApyF1FcvCxDZXjd1wW4LcUfwfVho/FsVpdQZEJSKXWaSTug+UIOrki8z94Ob5QRPHZnDXJbas+z40WrVqPyN2u0UBqBGNoQiJYKLc9Yd9cWCLWNB5/o3VggETyzoHokg0SDFsbvHK+bW1P8gOghilUDy3e5Jxot55og==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 12 Jun 2023 07:05:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.06.2023 21:55, Oleksii Kurochko wrote:
> Sometimes variables are located in .sbss section but it won't
> be mapped after MMU will be enabled.
> To avoid MMU failures .sbss should be mapped
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> xen/arch/riscv/xen.lds.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S
> index 74afbaab9b..9a2799bab5 100644
> --- a/xen/arch/riscv/xen.lds.S
> +++ b/xen/arch/riscv/xen.lds.S
> @@ -151,7 +151,7 @@ SECTIONS
> *(.bss.percpu.read_mostly)
> . = ALIGN(SMP_CACHE_BYTES);
> __per_cpu_data_end = .;
> - *(.bss .bss.*)
> + *(.bss .bss.* .sbss)
> . = ALIGN(POINTER_ALIGN);
> __bss_end = .;
> } :text
Two remarks, despite Alistair's ack: Wouldn't it be better to add .sbss.*
right away as well? And strictly speaking wouldn't it be more logical to
have .sbss ahead of .bss?
Jan
|
