[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/8] xen/riscv: introduce reset_stack() function
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Jun 2023 09:12:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZVY9mZhwQBYvAiAN649G3L5M1AD5Dt9to0VX+1Kaxc=; b=eQQ9lq/WofuVr/4PjxGf8RVkxmBtse8W/Gfue0t6y2eDNHlKIT+p4IX/cjqtZBI0MpKq4fLJsiWgPB6S2nRoshtt9nqKZz4cOqbgrc7I1RkalMtmWAKMNQGATCG71kKsWHGztjyDHG7eZD9g1icIjex+Ifq9lkz2Wd+hnIxKkoNFRGRWABZnGZ0GwtHL46+ufOaXEyhf38vKQovMqn0uMZ4h/nJDrGZfpuOSNqFe56TbXResEvpUCIP+kiOuBODp5CzrC2rlqXpt09Q0vc8KQmof+AKS4XHb4AtwHNXQOrEbVSm06FQJQchiqpRpAwDiEb4sUqLqNdJ3Zl6XUx4QAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CDIYjxN/dT0VOAxxjWcfU3nkDbrHzYw5UFmUzoxJ2iVkKN3NDLS935ByHi0CHJE+6gCUiS9De6eEfQT4/8RNyvoYJOH49kq7TCFl3xrb+Wp93Uz/Fv5Slu60PU693vKFoqCB7oosoVPvTlJV2ZqRB21Ub7W80yAyOVQNtV7vZGJWhMoSofrmJ7uTfkqpeFun8IyDW8pzQ2L6tzAeT4T17CFfNGrQuBnlYzGVvpgxTM3l/X5gCVz20idRq1u6nQRZmt5gdWbWbuWHrqMnfnGFK8KV5mxRO0aLedKrSmSZh82nulk8nAN2+TdK4yeEGa+T7n0gcYXRdU5G9Pe3qkxjQg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 12 Jun 2023 07:12:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.06.2023 21:55, Oleksii Kurochko wrote:
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
This wants addressing the "Why?" aspect in the description. Is the present
code wrong in some perhaps subtle way? Are you meaning to re-use the code?
If so, in which way (which is relevant to determine whether the new
function may actually continue to live in .text.header)?
Jan
> --- a/xen/arch/riscv/riscv64/head.S
> +++ b/xen/arch/riscv/riscv64/head.S
> @@ -27,8 +27,14 @@ ENTRY(start)
> add t3, t3, __SIZEOF_POINTER__
> bltu t3, t4, .L_clear_bss
>
> + jal reset_stack
> +
> + tail start_xen
> +
> +ENTRY(reset_stack)
> la sp, cpu0_boot_stack
> li t0, STACK_SIZE
> add sp, sp, t0
>
> - tail start_xen
> + ret
> +
|
