[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 2/3] libxl: Call libxl__virtio_devtype.set_default() early enough
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 12 Jun 2023 15:09:21 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Erik Schilling <erik.schilling@xxxxxxxxxx>
- Delivery-date: Mon, 12 Jun 2023 14:09:42 +0000
- Ironport-data: A9a23:FIBFEa3sjYjnny+QevbD5ZF2kn2cJEfYwER7XKvMYLTBsI5bp2RVy TBJWm+Baf2LNzbwL99wYdji8kJXvMKGm9NqTwJopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gJnP6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfEXxo0 vJGBG82Zz+Zh/Ob7pCxG+p0v5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiHJwMxB/J+ Dmfl4j/KgATG/KW2Sugy2uLiN/RoRLaQJ5PN6Lto5aGh3XMnzdOWXX6T2CTv/ijh1W+HdFCL kUO0i4vq6Eo8wqsVNaVdw21pjuIswARX/JUEvYm80edx6yS5ByWbkAGQSRGc8cOr9ItSHoh0 Vrht9H0AT1itpWFRHTb8a2bxRusOC4eIGkeIyAZTBcZ5MXLpIA1hwjICNF5H8adlcHvEC332 HWGoTYWgK1Wic8Qy779+VHBiiir4J/TQWYd7wHaTiSv4wV/aYONY42u4ELcq/FaI+6xS1Cdv HkJho6G6+EUDJyXvCiMRuwXG/ei4PPtGDrYjF10A4g69xyi/neiecZb5zQWDEpzM8VCYjTpY UvXuAVezJtSOnKwaulweY3ZI80ywLLpD9jNSvHeZd0IaZ90HDJr5wk3OxTWhTq01hFxz+dmY 8zznduQ4WgyGblB6zToa7gm2JAxxjET60HZFJPj9kHyuVaBX0J5WYvpIXPXMLBntvPf+1SIm zpMH5DUkksCCYUSdgGSqNdOdg5ScBDXELis86Rqmvi/zh2K8Y3LI9vY2vsfdoNshMy5fc+Yr yjmCie0JLcS7EAryDlmiVg5MtsDpb4l8RoG0dUEZD5EIUQLb4e197s4fJAqZ7Qh/+EL5acqH 6dYI5XcWqUXFmqvF9EhgX7V9tUKSfhWrVjWY3rNjMYXIvaMuDAlCve7J1CypUHi/wK8tNcko q3I6+8oacNreuiWN+6PMKjH5wro7RAgdBdaAxOgzi97JB+9r+CH6kXZ0pcKHi37AU+anmvBi 1fHWElwSCuki9ZdzeQlTJus9++Be9aS1GIAd4UHxd5a7RXnw1c=
- Ironport-hdrordr: A9a23:9pBM0Kl75oQgA8RNxbrZvIfqWK/pDfIA3DAbv31ZSRFFG/Fwwf re+8jzsiWZtN9xYh4dcLW7U5VoLkmzyXcY2+gs1NWZLWrbURqTTL2KhLGKq1eMJ8SZzJ856U 4KSdkdNDSfNykDsS/S2njdL/8QhPWB7aC0laP/4h5WPHpXgnhbnmFE49CgYzRLeDU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Jun 02, 2023 at 11:19:08AM +0530, Viresh Kumar wrote:
> The _setdefault() function for virtio devices is getting called after
> libxl__prepare_dtb(), which is late as libxl__prepare_dtb() expects the
> defaults to be already set by this time.
>
> Call libxl__virtio_devtype.set_default() from
> libxl__domain_config_setdefault(), in a similar way as other devices
> like disk, etc.
>
> Suggested-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
