Re: [PATCH] tools/xenstored: Correct the prototype of domain_max_chk()

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Mon, Jun 12, 2023 at 6:13 AM Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Some version of GCC will complain because the prototype and the
> declaration of domain_max_chk() don't match:
>
> xenstored_domain.c:1503:6: error: conflicting types for 'domain_max_chk' due 
> to enum/integer mismatch; have '_Bool(const struct connection *, enum 
> accitem,  unsigned int)' [-Werror=enum-int-mismatch]
>  1503 | bool domain_max_chk(const struct connection *conn, enum accitem what,
>       |      ^~~~~~~~~~~~~~
> In file included from xenstored_domain.c:31:
> xenstored_domain.h:146:6: note: previous declaration of 'domain_max_chk' with 
> type '_Bool(const struct connection *, unsigned int,  unsigned int)'
>   146 | bool domain_max_chk(const struct connection *conn, unsigned int what,
>       |      ^~~~~~~~~~~~~~
>
> Update the prototype to match the declaration.
>
> This was spotted by Gitlab CI with the job opensuse-tumbleweed-gcc.
>
> Fixes: 685048441e1c ("tools/xenstore: switch quota management to be table 
> based")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
Tested-by: Jason Andryuk <jandryuk@xxxxxxxxx>

This fixes the issue on Fedora 38, too.

Thanks,
Jason