[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: minor tidying of identify_cpu()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 13 Jun 2023 08:42:54 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q+teAMRlfiEyZECXtGraSo49mSNqG08y085bVVPPq2w=; b=OAxkDqSgQ/1bLBBFd62b/HfswmaBOXDNxhFjrZzWPpQ681kb95HE6/tHUwfGcmLNcM5zJTLDYc2YqlmlMXHHHDwa/km0+a2R2pVMu+8H80eiv5yNqSUQKDnwAIJ3eCT3ltHm4oF6rHIR/DfFUrbIXr2NuQDWQRlPuyepwbQC4g+ebDvWkHJKbj8drLE36UAQqg+sqPDi80xJoFOxC9LZKp53I79+xo51CSSD6Jy9ibZtu+lWpN6hK03/HymdHVqpcpzJSIlqFtXWuH5FzNi4Kq71VZChYS+gnul5j1jGVWXAzRx2iCmj/BGJhiSHRSco9oXKW13DuqqSlEyrBqTBaw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7Djlj++AShDlq8sR2FKgg3EsV1tO73nVgfb05z0y8c8mPc4cAINke7wnCa+kwINVdRE48W828Ir6d8ZdGKgT/fcUmSO3qdbjuDDtQvVCWP21ssQuys1zgGp/ft1rhO9uNlyDKpwCUbN6TAJ9Sx7HKZzTHphmGWtdMGajzuNiPD5g57y/DA0O+aEZNC4rI4gOVrVMgUdnL1ayYdsDL9ukOiMz17ulzn7QOebema6K1evGGVL5xHxuhSEd3oJ1T3V+J8lu0coZxUVmt80Y6dcbo+V1++gqnZ5aXHGtyoryVdoZHGGL9r7yex9ZdU/kXTzWv5C5xbhxeFSCuIY5O5LfA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 13 Jun 2023 07:43:11 +0000
  • Ironport-data: A9a23:bNn7ZKimPMiFT91CBC+ffOkiX161TREKZh0ujC45NGQN5FlHY01je htvCGzQP/qMY2KkeIolPNy+oRkE75XTyYVlHgBsqnpnESwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyq0N8klgZmP6sT4gaFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQhby8dche82t6mwePlcPk92+ojAdTCadZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTlrq8z0ALNroAVIAUaemKYn/njthO3VdVPO V1I0AolkKdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ5iELJR9M6Saqt1ISrSHf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxod+51knHpU KA4pvWj
  • Ironport-hdrordr: A9a23:Nj/9H6k/V3judEnDZU1SRMg2V6/pDfOtimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WBjB8bZYOCGghriEGgG1+ffKlLbakrDH4JmtJ uINpIOcOEYbmIKx/oSgjPIderIqePvmM/HuQ6d9QYVcegAUdAD0+4NMHf+LqQAfngiOXNWLv qhz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYpILSIly95FMzQjlPybAt/S zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzS/Bky/JlZAkEuDzYJLiJaIfy/wzdZ9vfqmrCpe O84ivI+f4Drk85MFvF5ScFkDOQrQrGo0WStWNwx0GT7PARDQhKdPZplMZXdADU5FEnu8w52K VX33iBv54SFh/Ymj/hjuK4IS2Cu3DE1UbKq9Rj+EB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK 1rANvH7PhbfFuGZzSB11MfiOCETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76 DPM7hulrtJUsgKBJgNTdspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCek1JNdYou WzbLqZjx9BR6vDM7z/4HQQyGGyfIyUZ0Wd9v1j
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13/06/2023 7:12 am, Jan Beulich wrote:
> Fields that generic_identify() sets unconditionally don't need pre-
> setting. (In fact the compiler removes some of those assignments anyway,
> at least in release builds.)
>
> With the setting of ->cpuid_level to -1 gone, also drop the respective
> BUG_ON() from default_init().
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I have some far more extensive plans in this, but no work started yet.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.