[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: fix make rpmball
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 13 Jun 2023 12:00:52 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 13 Jun 2023 11:01:29 +0000
- Ironport-data: A9a23:5R74qKKK6bgzi9zfFE+RwZUlxSXFcZb7ZxGr2PjKsXjdYENS1TdWz mUaXzuDOPnYY2PzfNslbtzk8EgG7JKBx9FlTgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrbwP9TlK6q4mhA4AVlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4mKFN++ 9ooBQwjUSDdqOO8562EUtJF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHJwOxRbC/ j+uE2LREh8cMISS+H2+yCiP3O3klCnbcYk5PejtnhJtqALKnTFCYPEMbnO8pfC3okezQ9xbJ goY90IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6GAkAUQzgHb8Yp3Oc/XTEw3 0WFt8/oDzdo9raSTBqgGqy89G3of3JPdClbOHFCFFFeizX+nG0tpkPmfOZtNp6YsvPKKW/fw jqtsxcmvJxG2KbnyJ6HEUD7byOE/8aZEFBvul2IAgpJ/SsiOtf7OtXABUzzqK8Zcd3HFgTpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKRBaJxslcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIoQP8ktK1TWoHE3DaJ144wLuBJ0+U3YE c3CGftA8F5AUfg3pNZIb7p1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PXBt3VGJis+V2Pm /4Gbpvi9vmqeLGmCsUh2dJJfA9iwLlSLcyelvG7gcbafVM8RD98UaaMqV7jEqQ895loei7z1 inVcidlJJDX2BUr9S3ihqhfVY7S
- Ironport-hdrordr: A9a23:g5IvQawAljH+MxMmJPF9KrPwT71zdoMgy1knxilNoH1uEvBw8v rEoB1173LJYVoqMk3I+urgBED/exzhHPdOiOEs1NyZMDUO1lHHEL1f
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jun 13, 2023 at 12:55:13PM +0200, Olaf Hering wrote:
> Commit 438c5ffa44e99cceb574c0f9946aacacdedd2952 ("rpmball: Adjust to
> new rpm, do not require --force") attempted to handle stricter
> directory permissions in newer distributions.
>
> This introduced a few issues:
> - /boot used to be a constant prior commit
> 6475d700055fa952f7671cee982a23de2f5e4a7c ("use BOOT_DIR as xen.gz
> install location"), since this commit the location has to be
> referenced via ${BOOT_DIR}
> - it assumed the prefix and the various configurable paths match the
> glob pattern /*/*/*
>
> Adjust the code to build a filelist on demand and filter directories
> from an installed filesystem.rpm. This works on a SUSE system, and
> will likely work on a RedHat based system as well.
>
> Take the opportunity to replace the usage of $RPM_BUILD_ROOT with
> %buildroot, and use pushd/popd pairs.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
>
> v2: remove bogus pushd/popd pair, use pipe as delimiter for s command for
> consistency
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
