[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 02/42] mm: Move pte/pmd_mkwrite() callers with no VMA to _novma()
- To: "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>
- From: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
- Date: Tue, 13 Jun 2023 16:19:46 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhYJ198yachG0bkUeuem6pdiFKP0nPpamQIWNCMRb3M=; b=Ig5LXmsdymy7wYIpd9yJEjSrUn9Jkoq//a170ise01IopUnoaC1SHQvpWuFOFUVsWP5edTkO8U+u0zTUsYk0xu2Uq8VHth9Qr93P6FJPy27MKWEcdtCKQhOyeG0CbPZ/xggJyrUfIhIvZiP/Cg7M+/qdu6iSaMTEZuNGh7MQwJIEsgtmGKiEQDQO/C3lgLV8j9t8iwjQRwetw8Hcv7dVxIYZpXgoqnl97l4VgqAaw4DM9DXvDdgHn5DVD9s91zw5eo1PpVx9NjMZq90s31RdYf28vj7qO/Kc+AmJYtO43lB7pkss77z460FHrXjPYPGQARDfHgG5Q3gSFfeinXU+1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RcMyB/++InbxWu8gaP9ae4ftXUitO56Ys5DOQ0u79tiOm/i7j4QhCix5pyz1nI078atl+I3+NUhzJtrj4+wJshfIgmI73NlSlo5WGBvDeA53w/B6bvbhFGj4KplHf7PFKgCQIf34NP6X9hKKRZ9skaZlIeiKbumxh4LAHnbuAGniJvQbdmJvgq1WS7yrlM581cCRlmmp+LRM+yn3VGYqZs8iBA7eWjrmaPYHAWpJjJilxMCLqo4zJpWtllWX+ZXMiLCl1C7juCkOihyELGOeLoVHr6ImoVkYgWuDex5xlay5ydKHnTEEPyPlFlPQTeX4Vi1fFvfXOhJxIgOCoBV12w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>, "kcc@xxxxxxxxxx" <kcc@xxxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "nadav.amit@xxxxxxxxx" <nadav.amit@xxxxxxxxx>, "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>, "david@xxxxxxxxxx" <david@xxxxxxxxxx>, "Schimpe, Christina" <christina.schimpe@xxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "Torvalds, Linus" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "jannh@xxxxxxxxxx" <jannh@xxxxxxxxxx>, "dethoma@xxxxxxxxxxxxx" <dethoma@xxxxxxxxxxxxx>, "broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "mike.kravetz@xxxxxxxxxx" <mike.kravetz@xxxxxxxxxx>, "pavel@xxxxxx" <pavel@xxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "linux-api@xxxxxxxxxxxxxxx" <linux-api@xxxxxxxxxxxxxxx>, "john.allen@xxxxxxx" <john.allen@xxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "jamorris@xxxxxxxxxxxxxxxxxxx" <jamorris@xxxxxxxxxxxxxxxxxxx>, "bsingharora@xxxxxxxxx" <bsingharora@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "oleg@xxxxxxxxxx" <oleg@xxxxxxxxxx>, "fweimer@xxxxxxxxxx" <fweimer@xxxxxxxxxx>, "keescook@xxxxxxxxxxxx" <keescook@xxxxxxxxxxxx>, "gorcunov@xxxxxxxxx" <gorcunov@xxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "szabolcs.nagy@xxxxxxx" <szabolcs.nagy@xxxxxxx>, "hjl.tools@xxxxxxxxx" <hjl.tools@xxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "debug@xxxxxxxxxxxx" <debug@xxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "Syromiatnikov, Eugene" <esyr@xxxxxxxxxx>, "Yang, Weijiang" <weijiang.yang@xxxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "Eranian, Stephane" <eranian@xxxxxxxxxx>
- Delivery-date: Tue, 13 Jun 2023 16:20:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZnYu5myZdSN5guk62QnYDURPfWq+IWqsAgACP+gA=
- Thread-topic: [PATCH v9 02/42] mm: Move pte/pmd_mkwrite() callers with no VMA to _novma()
On Tue, 2023-06-13 at 10:44 +0300, Mike Rapoport wrote:
> > Previous patches have done the first step, so next move the callers
> > that
> > don't have a VMA to pte_mkwrite_novma(). Also do the same for
>
> I hear x86 maintainers asking to drop "previous patches" ;-)
>
> Maybe
> This is the second step of the conversion that moves the callers ...
Really? I've not heard that. Just a strong aversion to "this patch".
I've got feedback to say "previous patches" and not "the last patch" so
it doesn't get stale. I guess it could be "previous changes".
>
> > pmd_mkwrite(). This will be ok for the shadow stack feature, as
> > these
> > callers are on kernel memory which will not need to be made shadow
> > stack,
> > and the other architectures only currently support one type of
> > memory
> > in pte_mkwrite()
> >
> > Cc: linux-doc@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: linux-s390@xxxxxxxxxxxxxxx
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: linux-arch@xxxxxxxxxxxxxxx
> > Cc: linux-mm@xxxxxxxxx
> > Signed-off-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
>
> Reviewed-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>
Thanks!
|
