[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/evtchn: Purge ERROR_EXIT{,_DOM}()



Hi,

On 13/06/2023 17:22, Andrew Cooper wrote:
These are disliked specifically by MISRA, but they also interfere with code

Please explicitly name the rule.

legibility by hiding control flow.  Expand and drop them.

  * Rearrange the order of actions to write into rc, then render rc in the
    gdprintk().
  * Drop redundant "rc = rc" assignments
  * Switch to using %pd for rendering domains

No functional change.  Resulting binary is identical.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

[...]

base-commit: f29363922c1b41310c3d87fd9a861ffa9db9204a

I notice you have a few e-mail contain this tag. This is a pretty useful when reviewing patches. Do you know which tool is creating it?

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.