[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/gnttab: Purge PIN_FAIL()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Jun 2023 08:46:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=igjqGgjmt1+Xt324yQ1LN2tc426yds9pUYkuR9saag8=; b=DiZOwIY5WBK2Df/RiQRpFtv2TueRYOFrLduiVwdXUrPhHHodhymktN3OQALGIaxlgCzCFG6x5TdzQor2dEjYww435sYVtxSChGD39Op1CJJZ/exiFBCVZIPfqi6X5UUzjBtf1pTuBCfEWkbDtNYWWvMVMDZAb0xCHP8iWVUOK+iXjMPJKC7LSwucgr89WpzQ3GWtBJ1vMZGcqlOVnTf/hZyFv68lxDrtj5/vE1ITHHO66YyJ/6hUu3uZ36qJJWZmol2cSf7mFGwxvmTDqfKUr7Og4U4woHujvNCY9WGTS+hYgsKRGTZZ366h24w1pvQIDGwMgp7MEvTEVzHVG3Wjjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDeWjC1lHBRRsAgADA7cX+qwdJquASlsWkB0diOKL9Xn5sp4y2FvWSWQObUpvF7addWhqRILB+pj9D+pG90+WFBwty8IKZlOzZtTEa0v8vXH7+vHsYjuzyyL3acFWZuKpbaAjSYPUjaqmNZR6LO41YfV5uYq4KL/rudUMo41BdkW0JnLXrLyqWdxKUKtqzEbF0BxnYxbyh4zLaTt1ZD6RWR4GGrJMa2vu5HgNocpQPPg5iV0jrtmCRIOMmiijfF+cNnZ5y6YocXx/kEtJ3PLLsRkm/dCkUTfYwX4JBdv3s09BrftlOUoUF5eU7Gf9lwl65zvy0GOtR4ZILFSlBWKCQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 06:47:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.06.2023 18:52, Andrew Cooper wrote:
> @@ -1062,9 +1081,13 @@ map_grant_ref(
> ((act->domid != ld->domain_id) ||
> (act->pin & GNTPIN_incr2oflow_mask(pin_incr)) ||
> (act->is_sub_page)) )
> - PIN_FAIL(act_release_out, GNTST_general_error,
> + {
> + gdprintk(XENLOG_WARNING,
> "Bad domain (%d != %d), or risk of counter overflow %08x,
> or subpage %d\n",
> act->domid, ld->domain_id, act->pin, act->is_sub_page);
> + rc = GNTST_general_error;
> + goto act_release_out;
Nit: One too deep indentation on these last two lines above. With that
adjusted:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
