[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Remove stray semicolon at VREG_REG_HELPERS/TLB_HELPER* callers
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Jun 2023 11:52:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=emQ64Lv88G/BXXTzejJVzE/hH+/6Uqek0GKlq2M4ZaU=; b=DSeYLkFw/JtisFXjHTbbgvGhqejAd6VC0gRL+jF8zt5jrETnCknFcHAAsg5BS7ihxMs1rtAQ7Hf+yHMAi6eVEjSn9KS7HNHF+om4u/BlUABIQtwUKYiGRmAPa0uxT06ukN8aOIBgCgA23v7X64b7XgjFbkU7WptkHXLufEy5bGr3LyYpLWLoPAhjVE8xLdEoyjx+bQ4+c29adSl3QcJrJtN/hQByo42bJtZBk53T9LRS0S8OK/2XxNDwICWxhXohpmXYh6aCxAJxSdmr6Zg7OTmc4WJnEzSoSSpZngBoPwfddD3nnuftE42mrWnqsX6It7c5cERrlQfyIDFq7SDoDw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fY/uEuNp93tAcB0oZEYxiML7pO48uNenoCpm9kjIKspAjJy9Huy1h19jHcqlDVrRWGgCOoDSg2ZjATq4heP0An43hfCZW0k7en55QHsWuI2kLjoXkYF9aUp7Q4NUVNd76DfwlVcJnDlkCyd62O/t7qOoYdfCkRDppCqmy80aho2wcx1LsK6rac3UQ92AQ96q0Rb3AUeBgMpcZZRpRfL1/1NcA1NhNNA/agkBnvnEwuMbGz0ciVPB580To7zRcvrR2v4G53S9UztWqj3I+GATyrqneZdGqvaKcsjxUYECxaMh+iGoFGsg+4Ux2LqEnc9TbmR3Ga/bMFEHGBHLvLe1tA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Jun 2023 09:52:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.06.2023 11:41, Michal Orzel wrote:
> This is inconsistent with the rest of the code where macros are used
> to define functions, as it results in an empty declaration (i.e.
> semicolon with nothing before it) after function definition. This is also
> not allowed by C99.
>
> Take the opportunity to undefine TLB_HELPER* macros after last use.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> Discussion:
> https://lore.kernel.org/xen-devel/17C59D5C-795E-4591-A7C9-A4C5179BF373@xxxxxxx/
>
> Other empty declarations appear at callers of TYPE_SAFE and Linux module
> macros like EXPORT_SYMBOL for which we need some sort of agreement.
As said elsewhere, I think we should finally get rid of EXPORT_SYMBOL().
For TYPE_SAFE() I think some re-arrangement of the macros can address
the Misra concern.
Jan
|
